fix text - missing D in CRD

[shay-berman]

No description provided.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[saad-ali]

/lgtm
/approve

@shay-berman could you make sure to sign the CNCF CLA. Once you've done that this should merge.

[k8s-ci-robot]

New changes are detected. LGTM label has been removed.

[shay-berman]

I just changed the commit auther to be my ibm email (as mentioned HERE).

Will keep you update when I will finish the CNCF CLA signing.

[saad-ali]

/approve cancel
/lgtm cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shay-berman
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: saad-ali

If they are not already assigned, you can assign the PR to them by writing /assign @saad-ali in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[saad-ali]

@msau42 pointed out CR is correct here (Custom Resource not Custom Resource Definition). Maybe we can expand out the terms instead of using the acronym (and maybe link to the definitions) for clarity.

[shay-berman]

1. So maybe it should be "object" instead of CR? (the word 'object' mentioned in the begining of the sentence so it will be consistent)

2. In addition we can add CRD and link to the CSIDriver CRD in the beginning of the page
   "The CSIDriver Kubernetes API object CRD serves two purposes"

Thoughts?

[shay-berman]

I signed it

[shay-berman]

@saad-ali waiting for your inputs.

[saad-ali]

How about:

CSI drivers do not need to create the `CSIDriver` CRD or CR directly. Instead they may use the [cluster-driver-registrar](cluster-driver-registrar.md) sidecar container (customizing it as needed with startup parameters). When deployed with a CSI driver it automatically creates a `CSIDriver` CRD (if one doesn't already exist) and a `CSIDriver` CR to represent the driver.

This will have to be updated for 1.14.

[msau42]

This entire section is going to change signficantly after #121

[shay-berman]

@saad-ali is this PR still relevant or the #121 already covers it?

[k8s-ci-robot]

@shay-berman: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[shay-berman]

Hi @saad-ali
Not sure if this PR is relevant any more, since as @msau42 mentioned (and its already in the master branch for 1.14) the section was changed signficantly and fixed the CRD references.

So can i close this PR?

Suggestion - we may improve the text a bit (maybe as part of this PR) - and to add how the CSIDriver object of the CSI plugin is removed from k8s. (Because it only mentioned how "What creates the CSIDriver object").
Do you think we should mentioned it to complete the story of how the CSIDriver object removed if the CSI plugin removed from the cluster.

[msau42]

@shay-berman I think that's a great idea

[shay-berman]

ok @msau42

Can you please approve that the deletion process is as follow (and then i will update the PR accordingly):
"
What deletes the CSIDriver object of the plugin?
The CSIDriver object of the specific CSI plugin is automatically removed when the CSI plugin(csi-controller statefulset and csi-node daemonset) removed from the cluster. Since the cluster-driver-registrar sidecar is part of the CSI plugin, then k8s identify that there is no more CSI pluginX registered so it deletes the CSIDriver object of the CSI plugin.
"

[msau42]

Nothing automatically removes the CSIDriver object. Right now we're recommending that drivers manually include the spec as part of their deployment, so when uninstalling all the specs of the driver, the CSIDriver object will get deleted

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.