Use v1.CSINode in the external-attacher #193

bertinatto · 2019-11-27T11:50:17Z

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR changes to attacher to use the GA version of the CSINode object.

Which issue(s) this PR fixes:

Fixes #197

Does this PR introduce a user-facing change?:

Action required: Use GA version of CSINode object. The external-attacher now requires Kubernetes 1.17.

bertinatto · 2019-12-03T13:06:48Z

/assign @msau42 @pohly

pohly · 2019-12-03T13:52:47Z

go.mod

 	k8s.io/klog v1.0.0
 )

-replace k8s.io/api => k8s.io/api v0.0.0-20190918195907-bd6ac527cfd2
+replace k8s.io/api => k8s.io/api v0.0.0-20191122220107-b5267f2975e0


Which version of Kubernetes is that? Can you record that in the commit message?

I assume all code coming from Kubernetes is at that version?

I vaguely remember seeing a script that can update all k8s dependencies. Was that something you wrote?

I took some snippet that was posted in one of the Kubernetes discussions around semantic versioning and added it to csi-release-tools, so it's now in all of our repos: https://github.com/kubernetes-csi/csi-release-tools/blob/master/go-get-kubernetes.sh

But it's impossible to tell from the result whether that script was used and thus whether the new replacements are consistent. We basically have to trust the PR submitter that they did the right thing. To reproduce it, the version given to the scripts needs to be documented, hence me question about the commit message.

Which version of Kubernetes is that? Can you record that in the commit message?

It was v1.17.0-rc.1, but today I updated it to v1.17.0-rc.2 (which was released yesterday). I also updated the commit message to record both the k8s version and how the dependencies were updated (using the go-get-kubernetes.sh script).

msau42 · 2019-12-03T18:49:59Z

cmd/csi-attacher/main.go

@@ -147,7 +147,7 @@ func main() {
 			pvLister := factory.Core().V1().PersistentVolumes().Lister()
 			nodeLister := factory.Core().V1().Nodes().Lister()
 			vaLister := factory.Storage().V1beta1().VolumeAttachments().Lister()


Hm we should use v1 VolumeAttachment too.

I can create another PR to address that...

bertinatto · 2019-12-04T18:54:56Z

/hold

Checking how to support older k8s releases

fejta-bot · 2020-03-03T19:46:21Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

bertinatto · 2020-03-04T07:37:55Z

/remove-lifecycle stale

jsafrane · 2020-04-16T11:29:24Z

@bertinatto, with Kubernetes 1.19, IMO we don't need to worry about supporting v1beta1 of CSINode. We can require Kubernetes 1.17. Can you please continue with this PR?

bertinatto · 2020-04-17T13:23:29Z

@bertinatto, with Kubernetes 1.19, IMO we don't need to worry about supporting v1beta1 of CSINode. We can require Kubernetes 1.17. Can you please continue with this PR?

Done, rebased PR. I think it's ready for review.

jsafrane · 2020-04-21T13:31:33Z

/lgtm
/hold cancel
/approve

k8s-ci-robot · 2020-04-21T13:31:37Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jsafrane]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jsafrane · 2020-07-30T17:21:07Z

/release-note-action-required

k8s-ci-robot · 2020-07-30T17:21:08Z

@jsafrane: the /release-note and /release-note-action-required commands have been deprecated.
Please edit the release-note block in the PR body text to include the release note. If the release note requires additional action include the string action required in the release note. For example:

```release-note
Some release note with action required.
```

In response to this:

/release-note-action-required

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot requested review from davidz627 and sbezverk November 27, 2019 11:50

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 27, 2019

bertinatto force-pushed the csinode_ga branch 3 times, most recently from 1a834e1 to 712af6c Compare November 27, 2019 15:42

k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 27, 2019

bertinatto changed the title ~~[WIP] Use v1.CSINode~~ [WIP] Use v1.CSINode in the external-attacher Nov 28, 2019

bertinatto force-pushed the csinode_ga branch from 712af6c to 32102db Compare December 3, 2019 09:26

bertinatto changed the title ~~[WIP] Use v1.CSINode in the external-attacher~~ Use v1.CSINode in the external-attacher Dec 3, 2019

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 3, 2019

k8s-ci-robot assigned msau42 and pohly Dec 3, 2019

pohly reviewed Dec 3, 2019

View reviewed changes

msau42 reviewed Dec 3, 2019

View reviewed changes

bertinatto force-pushed the csinode_ga branch 3 times, most recently from b652ad2 to f599fff Compare December 4, 2019 13:41

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 4, 2019

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 3, 2020

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 4, 2020

bertinatto force-pushed the csinode_ga branch from f599fff to 1ba3027 Compare April 17, 2020 11:11

bertinatto force-pushed the csinode_ga branch from 1ba3027 to c2be2ea Compare April 17, 2020 15:49

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2020

Use GA version of CSINode object

bcde5a6

bertinatto force-pushed the csinode_ga branch from c2be2ea to bcde5a6 Compare April 21, 2020 08:50

k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 21, 2020

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 21, 2020

k8s-ci-robot assigned jsafrane Apr 21, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 21, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 21, 2020

k8s-ci-robot merged commit 764b758 into kubernetes-csi:master Apr 21, 2020

k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jul 30, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use v1.CSINode in the external-attacher #193

Use v1.CSINode in the external-attacher #193

bertinatto commented Nov 27, 2019 •

edited by jsafrane

Loading

bertinatto commented Dec 3, 2019

pohly Dec 3, 2019

msau42 Dec 3, 2019

pohly Dec 3, 2019

bertinatto Dec 4, 2019

msau42 Dec 3, 2019

bertinatto Dec 4, 2019

bertinatto commented Dec 4, 2019

fejta-bot commented Mar 3, 2020

bertinatto commented Mar 4, 2020

jsafrane commented Apr 16, 2020

bertinatto commented Apr 17, 2020

jsafrane commented Apr 21, 2020

k8s-ci-robot commented Apr 21, 2020

jsafrane commented Jul 30, 2020

k8s-ci-robot commented Jul 30, 2020

Use v1.CSINode in the external-attacher #193

Use v1.CSINode in the external-attacher #193

Conversation

bertinatto commented Nov 27, 2019 • edited by jsafrane Loading

bertinatto commented Dec 3, 2019

pohly Dec 3, 2019

Choose a reason for hiding this comment

msau42 Dec 3, 2019

Choose a reason for hiding this comment

pohly Dec 3, 2019

Choose a reason for hiding this comment

bertinatto Dec 4, 2019

Choose a reason for hiding this comment

msau42 Dec 3, 2019

Choose a reason for hiding this comment

bertinatto Dec 4, 2019

Choose a reason for hiding this comment

bertinatto commented Dec 4, 2019

fejta-bot commented Mar 3, 2020

bertinatto commented Mar 4, 2020

jsafrane commented Apr 16, 2020

bertinatto commented Apr 17, 2020

jsafrane commented Apr 21, 2020

k8s-ci-robot commented Apr 21, 2020

jsafrane commented Jul 30, 2020

k8s-ci-robot commented Jul 30, 2020

bertinatto commented Nov 27, 2019 •

edited by jsafrane

Loading