Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capacity: run tests in parallel #607

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Apr 10, 2021

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

Sequentially, these tests run slowly (5 minutes). When allowed to run in parallel, they complete in 13 seconds.

The original reason for sequential execution (global registration of
metrics) had already been addressed in an earlier code refactoring
when moving the registration up the call stack, i.e. each test already
had a private registry.

Does this PR introduce a user-facing change?:

NONE

The original reason for sequential execution (global registration of
metrics) had already been addressed in an earlier code refactoring
when moving the registration up the call stack, i.e. each test already
had a private registry.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Apr 10, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 10, 2021
@pohly pohly mentioned this pull request Apr 10, 2021
@chrishenzie
Copy link
Contributor

/lgtm
/assign @msau42
for approval

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2021
@msau42
Copy link
Collaborator

msau42 commented Apr 12, 2021

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msau42, pohly

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 12, 2021
@k8s-ci-robot k8s-ci-robot merged commit d9e72fd into kubernetes-csi:master Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants