Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use registry.k8s.io for deployment #221

Closed
wants to merge 1 commit into from
Closed

Use registry.k8s.io for deployment #221

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deploy/kubernetes/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ spec:
serviceAccount: csi-resizer
containers:
- name: csi-resizer
image: gcr.io/k8s-staging-sig-storage/csi-resizer:canary
image: registry.k8s.io/k8s-staging-sig-storage/csi-resizer:canary
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image doesn't exist in the registry:

 % docker pull registry.k8s.io/k8s-staging-sig-storage/csi-resizer:canary
Error response from daemon: manifest for registry.k8s.io/k8s-staging-sig-storage/csi-resizer:canary not found: manifest unknown: Failed to fetch "canary" from request "/v2/k8s-staging-sig-storage/csi-resizer/manifests/canary".

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what should be the image name

Copy link
Contributor

@RaunakShah RaunakShah Sep 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest resizer image exists:

registry.k8s.io/sig-storage/csi-resizer:v1.5.0

How about changing it to that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I am not sure we missed something to publish the image to canary on the new registry. I will ask around.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help

Copy link
Contributor

@humblec humblec Sep 1, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm.. looks like canary is not promoted from staging.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So should I use v1.5.1 image name?

args:
- "--v=5"
- "--csi-address=$(ADDRESS)"
Expand Down