Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge pull request #588 from Kartik494/ValidateWebhook #613

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Merge pull request #588 from Kartik494/ValidateWebhook #613

merged 1 commit into from
Nov 29, 2021

Conversation

Kartik494
Copy link
Member

@Kartik494 Kartik494 commented Nov 18, 2021 •
edited by xing-yang
Loading

Backported #588

Cherry-pick #588: Updated `CertificateSigningRequest apiversion` to `V1`

@k8s-ci-robot
Merge pull request kubernetes-csi#588 from Kartik494/ValidateWebhook
c6da466 
Update CertificateSigningRequest apiversion to V1
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 18, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2021
@Kartik494
Copy link
Member Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Nov 18, 2021
@Kartik494
Copy link
Member Author

@xing-yang submitted this PR in reference for the follow up .

@chrishenzie
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2021
@xing-yang
Copy link
Collaborator

Can you add a release note?

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Nov 22, 2021
@Kartik494
Copy link
Member Author

@xing-yang Added the release note for the same.PTAL

@xing-yang
Copy link
Collaborator

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Kartik494, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7cf8fea into kubernetes-csi:release-5.0 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrishenzie chrishenzie Awaiting requested review from chrishenzie

@yuxiangqian yuxiangqian Awaiting requested review from yuxiangqian

Assignees

@chrishenzie chrishenzie

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Kartik494 @chrishenzie @xing-yang @k8s-ci-robot