k8s-infra: Use registry.k8s.io for deployment #687
Conversation
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ameukam The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ameukam
changed the title
|
@ameukam: Adding the "do-not-merge/release-note-label-needed" label and removing any existing "release-note-none" label because there is a "kind/deprecation" label on the PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
size/XS
|
@ameukam When we cut a release from these repos, the image was first uploaded to gcr.io/k8s-staging-sig-storage. Then we run a script to promote the image to the production location k8s.gcr.io/sig-storage. After that the image will also automatically show up in registry.k8s.io? We don't need to change our image promotion process, right? |
Yes. This is not impacting the release process for kubernetes or any Kubernetes project. |
|
Can you also help make the following changes since you are already updating csi-snapshotter files? Update the following line to: registry.k8s.io/sig-storage/snapshot-controller:v5.0.1 Update the following line to: registry.k8s.io/sig-storage/snapshot-validation-webhook:v5.0.1 |
ameukam
force-pushed
the
migrate-deploy-registry-k8s-io
branch
from
67952db to
97e6413
Compare
|
I see that you labeled this as "deprecation". Should we have a release note for that? |
A note mentioning the new endpoint should be added to the network security policies (firewall rules, etc...) for anyone using this endpoint. Still working on the proper note. We can hold this PR until k8s-infra has an official note if needed. |
|
/cherry-pick release-6.0 |
Related to: - kubernetes/k8s.io#3411 Switch to the new endpoint for container images. See: https://github.com/kubernetes/k8s.io/wiki/New-Registry-url-for-Kubernetes-(registry.k8s.io) Signed-off-by: Arnaud Meukam <[email protected]>
ameukam
force-pushed
the
migrate-deploy-registry-k8s-io
branch
from
97e6413 to
4d99b7f
Compare
|
/release-note-none |
|
@xing-yang: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@ameukam We are required to add a release note because the PR has the label "kind/deprecation". Can you add something like this: |
|
/hold According to https://groups.google.com/a/kubernetes.io/g/dev/c/DYZYNQ_A6_c/m/bhoEaoY_AAAJ it is too early to change references permanently. registry.k8s.io is still in a trial phase. |
k8s-ci-robot
added
the
do-not-merge/hold
|
@pohly looks like we can get this in now. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/release-note-none |
|
@pohly: you can not set the release note label to "release-note-none" because the PR has the label "kind/deprecation". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/kind cleanup |
k8s-ci-robot
added
the
kind/cleanup
|
I don't think that this is a deprecation of a feature in this repo as implied by the kind/deprecation label. As far as I can tell, upstream Kubernetes doesn't have specific instructions around this either, so I would merge this PR without a change note. We already did the same in other repos, too... |
|
@ameukam: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-rebase
|
@ameukam Can you rebase this PR and remove the "deprecation" label? |
| @@ -84,7 +84,7 @@ spec: | |||
| - name: socket-dir | |||
| mountPath: /csi | |||
| - name: csi-snapshotter | |||
| image: gcr.io/k8s-staging-sig-storage/csi-snapshotter:v5.0.1 | |||
| image: registry.k8s.io/sig-storage/csi-snapshotter:v5.0.1 | |||
| @@ -72,7 +72,7 @@ spec: | |||
| serviceAccount: csi-snapshotter | |||
| containers: | |||
| - name: csi-provisioner | |||
| image: k8s.gcr.io/sig-storage/csi-provisioner:v3.0.0 | |||
| image: registry.k8s.io/sig-storage/csi-provisioner:v3.0.0 | |||
| @@ -97,7 +97,7 @@ spec: | |||
| - name: socket-dir | |||
| mountPath: /csi | |||
| - name: hostpath | |||
| image: k8s.gcr.io/sig-storage/hostpathplugin:v1.7.2 | |||
| image: registry.k8s.io/sig-storage/hostpathplugin:v1.7.2 | |||
|
Hey @ameukam if you have not created PR for other sidecar repos ( like external-*..etc) in kubernetes-csi org, can I do that? |
|
@AdityaC45 This PR needs a rebase and update to address review comments. |
@AdityaC45 Hi, I got really busy with 1.25. Feel free to close this one if needed. Thank you so much for working on this. 🙇🏾♂️ |
|
@ameukam will create a new PR for this repo |
|
Can this PR be closed now? |
|
/close |
|
@ameukam: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature deprecation
What this PR does / why we need it:
Related to:
Switch to the new endpoint for container images. See: https://github.com/kubernetes/k8s.io/wiki/New-Registry-url-for-Kubernetes-(registry.k8s.io)
Special notes for your reviewer:
registry.k8s.iois currently a redirect to k8s.gcr.io. The change should be transparent to any pulling fromk8s.gcr.io.Does this PR introduce a user-facing change?: