-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport 688: Updating readme and webhook tempate to capture changes made for volumesnapshotclasses #700
Backport 688: Updating readme and webhook tempate to capture changes made for volumesnapshotclasses #700
Conversation
Hi @shawn-hurley. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
##### Volume Snapshot Content | ||
|
||
* Spec.VolumeSnapshotRef.Name must not be an empty string on creation | ||
* Spec.VolumeSnapshotRef.Namespace must not be an empty stringon creation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: space between stringon
README.md
Outdated
|
||
##### Volume Snapshot Classes | ||
|
||
* There can only be a single default volume snapshot class for a particular driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems confusing to me. Default can be one. But is it conveying a message that, only one snapshot class allowed per driver? may be not, but sharing the thought anyway. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for a driver, there can only be one volume snapshot class set as the default.
considering this is a backport, should this be fixed in the master branch and then re-backported or just fixed here?
There are 2 commits in #688. Can you backport both? |
/ok-to-test |
* Adding volumesnapshotclasses to admission configuration template
@xing-yang sorry about that, updated and waiting on tests to pass |
Can you also add the release notes that were in PR 688? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shawn-hurley, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind documentation
What this PR does / why we need it:
Updating the readme based on the new kubeconfig flag for the webhook and webhook template such that the webhook will be used for volumesnapshotclasses as well