Remove v1beta1 APIs and generated functions #704
Conversation
k8s-ci-robot
added
release-note
k8s-ci-robot
added
the
size/XXL
| type: string | ||
| description: parameters is a key-value map with storage driver specific parameters for creating snapshots. These values are opaque to Kubernetes. | ||
| description: parameters is a key-value map with storage driver specific | ||
| parameters for creating snapshots. These values are opaque to Kubernetes. |
There was a problem hiding this comment.
"storage: false" should be "storage: true"
| type: string | ||
| type: object | ||
| oneOf: | ||
| - required: ["snapshotHandle"] | ||
| - required: ["volumeHandle"] |
There was a problem hiding this comment.
Its listed as a step to perform under update-crd.sh here - https://github.com/kubernetes-csi/external-snapshotter/tree/master/client/hack
Not sure of the exact reasoning
There was a problem hiding this comment.
This "oneOf" needs to be manually added. I am wondering why it is removed.
There was a problem hiding this comment.
@RaunakShah i think @xing-yang saying right here in this script here it's mentioned that we should have to kept oneOf constraint to make sure only one of snapshotHandle volumeHandle is specified in source field.
There was a problem hiding this comment.
Ah I think I misread the document, thanks! I've added it back
k8s-ci-robot
added
the
needs-rebase
k8s-ci-robot
removed
the
needs-rebase
|
/retest |
1 similar comment
|
/retest |
|
/retest |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RaunakShah, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@RaunakShah can you backport this to release-6.0? |
|
what is the tracking issue for this change? |
|
This can use the general VolumeSnapshot enhancement issue: kubernetes/enhancements#177 (comment) |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
This PR removes the
VolumeSnapshotv1beta1APIs. It was deprecated in an earlier release and will be removed fromrelease-6.0onwards.Also make changes to the generated functions, scripts and README.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: