This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
Add approvers to facilitate project management #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
xing-yang
reviewed
Oct 28, 2020
OWNERS
Outdated
| - wlan0 | ||
| - brahmaroutu | ||
| - rrati | ||
|
|
There was a problem hiding this comment.
nit: remove the empty line
There was a problem hiding this comment.
Fixed. Please review.
brahmaroutu
force-pushed
the
add_approvers
branch
from
820f06f to
0d31481
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brahmaroutu, xing-yang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Jun 6, 2024
added issue templates to COSI sidecar
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Jun 6, 2024
Pass by-ref instead of by-value
BlaineEXE
referenced
this pull request
in BlaineEXE/cosi-api
Jun 14, 2024
added issue templates to COSI sidecar
BlaineEXE
referenced
this pull request
in BlaineEXE/cosi-api
Jun 14, 2024
Pass by-ref instead of by-value
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to pick up pace in merging initial code to move to alpha implementation ASAP. This requires us to have some approvers who are involved deeply in this project. Please approve this PR ASAP to get help us carry the work at a faster pace.
/assign @xing-yang @saad-ali