Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

crds: add kustomization.yaml #13

Merged
merged 2 commits into from
Dec 17, 2020
Merged

crds: add kustomization.yaml #13

merged 2 commits into from
Dec 17, 2020

Conversation

NicolasT
Copy link
Contributor

This kustomization simply lists all CRD manifests. As such it can be referred to from other layers to import/include all CRDs in another rendering.

If this gets merged, we can refer to it as a base in container-object-storage-interface-controllers deploy/base/kustomization.yaml instead of explicitly listing all CRD files (and keeping them in sync) as resources.

@NicolasT
crds: add kustomization.yaml
38cdd2f 
This `kustomization` simply lists all CRD manifests. As such it can be
referred to from other layers to import/include all CRDs in another
rendering.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @NicolasT!

It looks like this is your first PR to kubernetes-sigs/container-object-storage-interface-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/container-object-storage-interface-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @NicolasT. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 17, 2020
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 17, 2020
@NicolasT
crds: patch in api-approved label through Kustomization
584f54a 
This was taken from the `kustomization.yaml` found in the
`container-object-storage-interface-controller` repository which in turn
deploys these CRDs.

See: https://github.com/kubernetes-sigs/container-object-storage-interface-controller/blob/f6867a078f0b6254aadd61987e103174bfa6b870/deploy/base/kustomization.yaml#L18
@wlan0
Copy link
Contributor

wlan0 commented Dec 17, 2020

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2020
@wlan0
Copy link
Contributor

wlan0 commented Dec 17, 2020

Tested.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: NicolasT, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020
@wlan0
Copy link
Contributor

wlan0 commented Dec 17, 2020

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6b4158f into kubernetes-retired:master Dec 17, 2020
NicolasT added a commit to NicolasT/container-object-storage-interface-controller that referenced this pull request Dec 17, 2020
@NicolasT
deploy: use crds Kustomization from the API repo
7c519fe 
Instead of listing all CRD manifests and patching in the required
`api-approved` label in a Kustomization within this repository, use the
new Kustomization layer from the API repository as a base. This
simplifies the deployment machinery in this project.

See: kubernetes-retired/container-object-storage-interface-api#13
This was referenced Dec 17, 2020
Merged
Merged
shanduur pushed a commit to shanduur/container-object-storage-interface-api that referenced this pull request Jun 6, 2024
@NicolasT
deploy: use crds Kustomization from the API repo
1b4c259 
Instead of listing all CRD manifests and patching in the required
`api-approved` label in a Kustomization within this repository, use the
new Kustomization layer from the API repository as a base. This
simplifies the deployment machinery in this project.

See: kubernetes-retired#13
BlaineEXE pushed a commit to BlaineEXE/cosi-api that referenced this pull request Jun 14, 2024
@k8s-ci-robot
Merge pull request kubernetes-retired#13 from rrati/fake-client
afa665f 
Added fake client
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wlan0 wlan0 wlan0 approved these changes

@brahmaroutu brahmaroutu Awaiting requested review from brahmaroutu

@rrati rrati Awaiting requested review from rrati

Assignees

@wlan0 wlan0

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NicolasT @k8s-ci-robot @wlan0