This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
Update API based on latest spec #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wlan0
commented
Mar 24, 2021
wlan0
commented
- remove anonymous access mode from bucket and bucketclass
- refactor package
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wlan0 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
size/XL
jeffvance
reviewed
Mar 24, 2021
| Private bool `json:"private,omitempty"` | ||
| // +optional | ||
| PublicReadOnly bool `json:"publicReadOnly,omitempty"` | ||
| type RetentionPolicy string |
There was a problem hiding this comment.
The lastest kep pr defines this field as "deletionPolicy" based on review meeting consensus.
There was a problem hiding this comment.
Good catch. I’ll update it
jeffvance
reviewed
Mar 24, 2021
|
|
||
| const ( | ||
| RetentionPolicyRetain RetentionPolicy = "Retain" | ||
| RetentionPolicyDelete RetentionPolicy = "Delete" |
There was a problem hiding this comment.
and we've added a 3rd value: "ForceDelete"
|
@jeffvance fair point. While I’m happy to make changes here, let’s get the kep reviewed |
- remove anonymous access mode from bucket and bucketclass - refactor package
wlan0
force-pushed
the
master
branch
2 times, most recently
from
dbfa38f to
d17f24b
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
shanduur
pushed a commit
to shanduur/container-object-storage-interface-api
that referenced
this pull request
Jun 6, 2024
…uilds Added Dockerfile to build sidecar as well as sample driver
BlaineEXE
pushed a commit
to BlaineEXE/cosi-api
that referenced
this pull request
Jun 14, 2024
…uilds Added Dockerfile to build sidecar as well as sample driver
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.