This repository has been archived by the owner on Apr 17, 2019. It is now read-only.
[rescheduler] actually wait for pod to be scheduled #1630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @mwielgus |
| glog.Infof("Waiting for pod %s to be scheduled", podId(pod)) | ||
| time.Sleep(10 * time.Minute) | ||
| func waitForScheduled(client *kube_client.Client, podsBeingProcessed *podSet, pod *kube_api.Pod) { | ||
| for start := time.Now(); time.Since(start) < *podScheduledTimeout; time.Sleep(10 * time.Second) { |
There was a problem hiding this comment.
Not sure if you already have this dependency in contrib (and if not how easy it is to import it), but it would be great if you could use:
wait.Poll(...)
from: https://github.com/kubernetes/kubernetes/blob/master/pkg/util/wait/wait.go#L158
function instead.
Also, please make the sleep smaller (like 500ms or sth like that).
|
LGTM |
|
Automatic merge from submit-queue |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes/kubernetes#29023
This change is