Propagate StorageClass MountOptions to PVs created by nfs-client-provisioner

[pgagnon]

This PR will allow StorageClasses to propagate MountOptions to PVs provisioned by nfs-client-provisioner.

[wongma7]

/lgtm
thanks for the pr. I may wait a bit to merge it, I want to add #828 on top of this so that when a user puts mount options and the provisioner doesn't know what to do with them the user gets an error instead of the mount options being silently ignored

[wongma7]

also the test error is unrelated

[brandom]

@wongma7 Any chance this will be merged soon or is there a resource to help with build issues? I checked out @pgagnon's branch and tried to build but I get:

/go/src/github.com/kubernetes-incubator/external-storage/lib/controller/controller.go:853:53: cannot use claim (type *"github.com/kubernetes-incubator/external-storage/vendor/k8s.io/api/core/v1".PersistentVolumeClaim) as type *"github.com/kubernetes-incubator/external-storage/vendor/k8s.io/kubernetes/vendor/k8s.io/api/core/v1".PersistentVolumeClaim in argument to helper.GetPersistentVolumeClaimClass
/go/src/github.com/kubernetes-incubator/external-storage/lib/controller/controller.go:989:52: cannot use claim (type *"github.com/kubernetes-incubator/external-storage/vendor/k8s.io/api/core/v1".PersistentVolumeClaim) as type *"github.com/kubernetes-incubator/external-storage/vendor/k8s.io/kubernetes/vendor/k8s.io/api/core/v1".PersistentVolumeClaim in argument to helper.GetPersistentVolumeClaimClass

This is my first try at building a go project and I've read all the docs I could find. I installed the deps using glide install -v and then needed to do go get github.com/kubernetes-incubator/external-storage/lib/controller. It is possible I need a specific version of the controller, but I'm stuck.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: [email protected]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pgagnon]

@wongma7 I just merged your master branch into my fork in order to restore the ability to merge the PR automatically.

I had to do some history rewriting because my git client was configured with the wrong email address, so my apologies for the extra notifications you may have received.

[wongma7]

/lgtm
no problem! Let's just merge it, I still want to add some kind of interface to the Provisioners but it's taking me too long.

[pgagnon]

Thanks!