Skip to content
This repository has been archived by the owner on Sep 24, 2021. It is now read-only.

Switch to critest #146

Merged
merged 2 commits into from
May 26, 2017
Merged

Switch to critest #146

merged 2 commits into from
May 26, 2017

Conversation

heartlock
Copy link
Contributor

@heartlock heartlock commented May 17, 2017 •
edited
Loading

Signed-off-by: heartlock [email protected]
Closes: #143

  • Step1: enable critest in travis CI
  • Step2: delete reduplicate test case in the old e2e test framwork, only keep frakti-specific tests

@feiskyer But critest still test fail with frakti. @xlgao-zju Please read travis CI log.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@heartlock heartlock force-pushed the switch-critest branch 2 times, most recently from 6932d4c to 6747260 Compare May 17, 2017 16:36
@feiskyer
Copy link
Contributor

Yep, image related tests are failed because

RemoveImage from hyper runtime service failed: rpc error: code = 2 desc = conflict: unable to delete c75bebcdd211 (must be forced) - image is referenced in one or more repositories

This is a issue caused by hyperd, which doesn't accept removing a image via id:

# hyperctl rmi 3448f27c273f
Error remove the image(3448f27c273f): Error from daemon's response: conflict: unable to delete 3448f27c273f (must be forced) - image is referenced in one or more repositories

@heartlock
Copy link
Contributor Author

heartlock commented May 18, 2017 •
edited
Loading

@feiskyer We can send -f to hyperd or modify removeImage in cri-tools to fix this issue. which one is better?

@feiskyer
Copy link
Contributor

let's add force in hyperclient

@heartlock heartlock mentioned this pull request May 18, 2017
Merged
@heartlock
Copy link
Contributor Author

@feiskyer List image with digest still fail.

@feiskyer
Copy link
Contributor

weird, it success on my local environment. Could you add a log at here and run again?

@heartlock
Copy link
Contributor Author

I add log and run again, list image return nothing. Do you test with newest version hyperd?
I0519 03:57:02.934697 22272 manager.go:493] List images response []

@feiskyer
Copy link
Contributor

I'm testing it with hyperd 0.8.1, not master version.

@feiskyer
Copy link
Contributor

Update: the test also pass on hyperd master.

@feiskyer feiskyer closed this May 19, 2017
@feiskyer feiskyer reopened this May 19, 2017
@feiskyer
Copy link
Contributor

feiskyer commented May 19, 2017 •
edited
Loading

@heartlock Passed at #148. It upgraded docker to v1.13. Could you add a follow up based on it?

@heartlock
Copy link
Contributor Author

ok, will do it.

@xlgao-zju
Copy link
Contributor

This may be caused by kubernetes/kubernetes#43267 and the mixed-runtime.

@feiskyer
Copy link
Contributor

@xlgao-zju Right, so we are running with docker 1.13 in cri-tools.

@feiskyer
Copy link
Contributor

Some security contexts are not supported, we should skip those tests

@feiskyer
Copy link
Contributor

port mapping with host port and container port is also not supported yet (see #122 )

@feiskyer
Copy link
Contributor

@heartlock any updates on this?

@heartlock
Copy link
Contributor Author

@feiskyer Attach container TEST case block travis-ci so that test job exceeded the maximum time limit for jobs, and has been terminated. I do not know what the reason is because. It seems something wrong with hyperd. Please have a look.

feiskyer
feiskyer reviewed May 26, 2017
View reviewed changes
hack/test-e2e.sh Outdated
@@ -154,7 +154,7 @@ runTests() {

start_frakti

frakti::test::e2e
#frakti::test::e2e
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this now and remove e2e tests dup with critest.

@feiskyer
Copy link
Contributor

Filed hyperhq/hyperd#637 to fix attach problem.

@feiskyer feiskyer closed this May 26, 2017
@feiskyer feiskyer reopened this May 26, 2017
@heartlock heartlock mentioned this pull request May 26, 2017
Merged
@heartlock heartlock force-pushed the switch-critest branch 2 times, most recently from dc0150f to b2d9254 Compare May 26, 2017 10:27
@heartlock heartlock changed the title [WIP]switch to critest Switch to critest May 26, 2017
@heartlock
Copy link
Contributor Author

@feiskyer Ready for review!

@feiskyer feiskyer self-assigned this May 26, 2017
@feiskyer
Copy link
Contributor

@heartlock Cool

@feiskyer
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 26, 2017
@feiskyer feiskyer merged commit eeabc49 into kubernetes-retired:master May 26, 2017
@heartlock heartlock deleted the switch-critest branch May 26, 2017 13:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@feiskyer feiskyer feiskyer left review comments

Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@heartlock @k8s-reviewable @feiskyer @xlgao-zju @k8s-ci-robot