Skip to content
This repository has been archived by the owner on Sep 30, 2020. It is now read-only.

Use docker instead of rkt for regular etcdadm tasks (#4) #705

Merged

Conversation

ytsarev
Copy link
Contributor

@ytsarev ytsarev commented Jun 16, 2017

Motivation is to avoid serious memory leak on etcd nodes as in

Also it potentially mitigates issues #691 and #660 as the symptoms looks similar to our case.

Motivation is to avoid serious memory leak on etcd nodes as in
* coreos/bugs#1927
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2017
@codecov-io
Copy link

Codecov Report

Merging #705 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #705   +/-   ##
=======================================
  Coverage   35.31%   35.31%           
=======================================
  Files          53       53           
  Lines        3047     3047           
=======================================
  Hits         1076     1076           
  Misses       1802     1802           
  Partials      169      169

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4637d39...062ea37. Read the comment docs.

@mumoshu
Copy link
Contributor

mumoshu commented Jun 20, 2017

@ytsarev Thank you very much for your effort on this 👍 I've read through/connected all the referenced links in mind and this change looks good to me.

@mumoshu mumoshu merged commit 44e5e24 into kubernetes-retired:master Jun 20, 2017
@mumoshu mumoshu added this to the v0.9.7-rc.4 milestone Jun 20, 2017
@billyteves
Copy link

@mumoshu is the issue also exists in v0.9.6?

@mumoshu
Copy link
Contributor

mumoshu commented Jun 21, 2017 via email

@Vince-Cercury
Copy link

If I select containerRuntime: docker in cluster.yml, is that supposed to use docker for etcd setup? or this cluster.yml option is only used for Workers? What about Controllers?

@mumoshu
Copy link
Contributor

mumoshu commented Jul 13, 2017

@Vincemd It is supposed to use docker only for containers managed by kubelets when containerRuntime: docker is set. Both controllers and workers runs kubelets for scheduling various pods, so controllers do get affected by the option.

On the other hand, etcd isn't managed by k8s/kubelets hence it is always run by rkt.

@redbaron redbaron mentioned this pull request Jul 26, 2017
kylehodgetts pushed a commit to HotelsDotCom/kube-aws that referenced this pull request Mar 27, 2018
…m/etcdadm-rkt-to-docker

Use docker instead of rkt for regular etcdadm tasks (#4)
@mousavian mousavian deleted the upstream/etcdadm-rkt-to-docker branch February 25, 2019 04:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants