Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

build: Use k8s v1.24 for tests #1516

Merged
merged 1 commit into from
Aug 10, 2022
Merged

build: Use k8s v1.24 for tests #1516

merged 1 commit into from
Aug 10, 2022

Conversation

jimmidyson
Copy link
Contributor

@jimmidyson jimmidyson commented Aug 8, 2022 •
edited
Loading

No description provided.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 8, 2022
@k8s-ci-robot k8s-ci-robot requested review from danehans and font August 8, 2022 13:35
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 8, 2022
@jimmidyson jimmidyson marked this pull request as ready for review August 8, 2022 14:11
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2022
@k8s-ci-robot k8s-ci-robot requested a review from gyliu513 August 8, 2022 14:11
@jimmidyson jimmidyson requested review from makkes and removed request for gyliu513 August 8, 2022 14:11
@jimmidyson
Copy link
Contributor Author

Splitting into multiple PRs for easier review.

makkes
makkes reviewed Aug 9, 2022
View reviewed changes
charts/kubefed/templates/federatedtypeconfig.yaml Outdated Show resolved Hide resolved
scripts/download-binaries.sh Outdated Show resolved Hide resolved
scripts/download-binaries.sh Show resolved Hide resolved
@makkes makkes mentioned this pull request Aug 9, 2022
Merged
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 9, 2022
@jimmidyson
Copy link
Contributor Author

/hold

Blocking until #1521 is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 9, 2022
@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 10, 2022
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 10, 2022
@jimmidyson
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 10, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jimmidyson, makkes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@makkes
Copy link
Contributor

makkes commented Aug 10, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit 76ad91b into kubernetes-retired:master Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@irfanurrehman irfanurrehman irfanurrehman left review comments

@makkes makkes makkes approved these changes

@danehans danehans Awaiting requested review from danehans

@font font Awaiting requested review from font

@RainbowMango RainbowMango Awaiting requested review from RainbowMango

Assignees

@makkes makkes

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jimmidyson @k8s-ci-robot @makkes @irfanurrehman