Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

Refactor and cleanup validation unit tests #992

Merged
merged 3 commits into from
Jun 18, 2019
Merged

Refactor and cleanup validation unit tests #992

merged 3 commits into from
Jun 18, 2019

Conversation

font
Copy link
Contributor

@font font commented Jun 15, 2019

@font font requested review from marun and xunpan June 15, 2019 01:22
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 15, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: font

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 15, 2019
@font
Copy link
Contributor Author

font commented Jun 17, 2019

This appears to have hit an unrelated IngressDNS failure Waiting for the IngressDNS object to have correct status. I've force-pushed an amended commit with no new changes to force a new build while preserving the old build logs located here https://travis-ci.org/kubernetes-sigs/kubefed/builds/545998403.

@font font requested a review from shashidharatd June 17, 2019 19:25
@marun
Copy link
Contributor

marun commented Jun 17, 2019

LGTM Thank you!

@shashidharatd
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2019
@k8s-ci-robot k8s-ci-robot merged commit 0085f3e into kubernetes-retired:master Jun 18, 2019
@font font deleted the val-unit-test branch June 25, 2019 01:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marun marun Awaiting requested review from marun

@xunpan xunpan Awaiting requested review from xunpan

@shashidharatd shashidharatd Awaiting requested review from shashidharatd

Assignees

@shashidharatd shashidharatd

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@font @k8s-ci-robot @marun @shashidharatd