Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove node check (for vk) and serviceaccount check #1317

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlbeeSo
Copy link
Member

@AlbeeSo AlbeeSo commented Feb 11, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

VolumeAttchment will not be created when the pod scheduled to VK.
For service account not exists, got event like

  Warning  FailedAttachVolume  2s (x4 over 7s)  attachdetach-controller  AttachVolume.Attach failed for volume "pv-oss" : rpc error: code = Internal desc = failed to create ossfs pod: pods "csi-fuse-ossfs-" is forbidden: error looking up service account ack-csi-fuse/a-fake-sa: serviceaccount "a-fake-sa" not found

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?


Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Feb 11, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2025
@mowangdk
Copy link
Contributor

@tydra-wang ptal

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2025
Copy link
Contributor

@tydra-wang tydra-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlbeeSo, tydra-wang
Once this PR has been reviewed and has the lgtm label, please ask for approval from mowangdk. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants