-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update manifest for Kubernetes 1.15 #322
Update manifest for Kubernetes 1.15 #322
Conversation
The sidecar container is deprecated. CSIDriver instance must be created manually instead
Welcome @jsafrane! |
Could you clarify on what is not working on 1.14? I have e2e tests testing against 1.14, and don't find any obvious issue. |
- name: csi-provisioner | ||
image: quay.io/k8scsi/csi-provisioner:v1.1.0 | ||
image: quay.io/k8scsi/csi-provisioner:v1.3.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this change compatible with k8s 1.14? We are planing to do a 0.4 release with is supposed to be compatible with 1.14. So don't want to break the driver on 1.14
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kubernetes docs claim that 1.3.0 works with 1.14
https://kubernetes-csi.github.io/docs/external-provisioner.html
@@ -193,7 +155,7 @@ spec: | |||
- name: socket-dir | |||
mountPath: /var/lib/csi/sockets/pluginproxy/ | |||
- name: csi-attacher | |||
image: quay.io/k8scsi/csi-attacher:v1.1.0 | |||
image: quay.io/k8scsi/csi-attacher:v1.2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I wrote above, cluster-driver-registrar sidecar container was not released in 1.14 and the version from 1.13 does not work. It most probably does not create CSIDriver instance. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane, leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What is this PR about? / Why do we need it?
deploy/kubernetes
does not work since Kubernetes 1.14:CSIDriver
instance during installation.