-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add well-known topology label #773
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ayberk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @wongma7 |
@ayberk: GitHub didn't allow me to assign the following users: AndyXiangLi. Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@@ -41,11 +41,14 @@ const ( | |||
|
|||
const ( | |||
DriverName = "ebs.csi.aws.com" | |||
TopologyKey = "topology." + DriverName + "/zone" | |||
AwsPartitionKey = "topology." + DriverName + "/partition" | |||
AwsAccountIDKey = "topology." + DriverName + "/account-id" | |||
AwsRegionKey = "topology." + DriverName + "/region" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we deprecate the region one as well? It seems like we only set it in the outposts case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm makes sense yeah. I didn't include it because as you said we only use it internally, but that would be more future-proof.
Pull Request Test Coverage Report for Build 1728
💛 - Coveralls |
LGTM, let's wait for another approval :-) |
/lgtm |
sorry I think you have to rebase since I moved some stuff to node_linux.go ... |
|
/lgtm |
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
See #729. This is the first part where we start writing the label and also give priority to it when reading topology labels. This change is completely backward-compatible with no change in behavior as far as users are concerned.
What testing is done?
Unit tests
Single AZ e2e (there was one failed case that should be unrelated, probably flake)