Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilize latest go sdk to ensure createVolume idempotency #981

Closed
wants to merge 1 commit into from

Conversation

AndyXiangLi
Copy link
Contributor

@AndyXiangLi AndyXiangLi commented Jul 21, 2021

Is this a bug fix or adding new feature?
Fixes #165

What is this PR about? / Why do we need it?
EBS team has updated the createVolume api to accept ClientToken in the createVolume request. doc here
With ClientToken, EBS will be able to ensure the createVolume Idempotency at Api level.
What testing is done?
unit test
sanity test
Manually tested described in the original re-produce step and observed only one volume is created

csc controller create-volume -e <endpoint> --cap 1,1 xiang-test --req-bytes 1024000 & \
> csc controller create-volume -e <endpoint> --cap 1,1 xiang-test --req-bytes 1024000
[1] 2801280
Create volume request for xiang-test is already in progress

Please use -h,--help for more information
"vol-0c8323ca0f9ab1a6d"	1073741824

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyXiangLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from d-nishi and ddebroy July 21, 2021 22:58
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Race condition in CreateVolume
2 participants