-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop using master nodes #92
Milestone
Comments
owenhaynes
pushed a commit
to owenhaynes/alb-ingress-controller
that referenced
this issue
May 10, 2017
Closed
igorcanadi
added a commit
to rockset/alb-ingress-controller
that referenced
this issue
May 11, 2017
kubernetes-sigs#92 Ignore master nodes
We'll be going forward with using the presence of the following label as an indicator that the node is a master node.
With this, we'll be taking the approach made in #94 (thanks @owenhaynes) but going forward with slightly different code due to how the ingress library has changed and this difference in the labeling mentioned above. |
joshrosso
added a commit
that referenced
this issue
Sep 8, 2017
- Excludes all master nodes from node list returned by the lister. This prevents masters from being added as part of an ALB's targetgroup. - The mechanism to determine whether a node is a master is based on the presence of the label "node-role.kubernetes.io/master". The use of this label is based on the discussion at kubernetes/kubernetes#41835. - Resolves #92
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Stop master nodes being added to the target group. Master nodes should not handle this traffic.
The text was updated successfully, but these errors were encountered: