e2e: Use Helm chart from the commit #2435
Conversation
k8s-ci-robot
added
cncf-cla: yes
Codecov Report
@@ Coverage Diff @@
## main #2435 +/- ##
=======================================
Coverage 53.35% 53.35%
=======================================
Files 140 140
Lines 7962 7962
=======================================
Hits 4248 4248
Misses 3397 3397
Partials 317 317 Continue to review full report at Codecov.
|
johngmyers
force-pushed
the
e2e-chart
branch
2 times, most recently
from
47a9ad6 to
b6a1098
Compare
johngmyers
force-pushed
the
e2e-chart
branch
from
b6a1098 to
78f0ffd
Compare
test/framework/options.go
Outdated
| @@ -51,6 +53,9 @@ func (options *Options) Validate() error { | |||
| if len(options.AWSVPCID) == 0 { | |||
| return errors.Errorf("%s must be set!", "aws-vpc-id") | |||
| } | |||
| if len(options.HelmDir) == 0 { | |||
There was a problem hiding this comment.
Comment from PR 2433,
@kishorj 2 hours ago
why not make it optional? If set, test uses the specified directory, otherwise default to the aws eks-charts repo.
@johngmyers 1 hour ago
Making it optional adds complexity for no obvious reason and admits the possibility of missing an incompatibility between the repo's chart and the repo's image.
Could you give more information on the use case for this? Why would one not want to put the repo's Helm chart under test?
@kishorj now
One example is the canary script which we run against the release version. In this case we want the last published image and the chart, not the recent one from the repo.
There was a problem hiding this comment.
One possibility would be to download the published chart in the script, outside of ginkgo. But it might work to rely on the script's current helm repo add and pass the name of the chart.
|
I can squash if requested. |
kishorj
added
the
tide/merge-method-squash
not necessary, I set to squash on merge :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johngmyers, kishorj The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
* e2e: Use Helm chart from the commit * Address review comments
Issue
Description
Change the e2e tests to use the Helm chart from the commit, not from the
mainbranch. The Helm chart from the commit should be what is under the test.Checklist
README.md, or thedocsdirectory) (N/A)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯