Configurable Attributes #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0fls
force-pushed
the
accesslogging
branch
3 times, most recently
from
a169c7d to
e824d4d
Compare
bigkraig
reviewed
Nov 17, 2017
| lb.logger.Infof("Start ELBV2 tag modification.") | ||
| if err := albelbv2.ELBV2svc.UpdateAttributes(lb.Current.LoadBalancerArn, lb.DesiredAttributes); err != nil { | ||
| rOpts.Eventf(api.EventTypeWarning, "ERROR", "%s tag modification failed: %s", *lb.Current.LoadBalancerName, err.Error()) | ||
| lb.logger.Errorf("Failed ELBV2 (ALB) tag modification: %s", err.Error()) |
bigkraig
reviewed
Nov 17, 2017
pkg/aws/elbv2/elbv2.go
Outdated
| @@ -220,3 +249,14 @@ func (e *ELBV2) UpdateTags(arn *string, old util.Tags, new util.Tags) error { | |||
|
|
|||
| return nil | |||
| } | |||
|
|
|||
| // UpdateAttributes compares the new (desired) attributes against the old (current) tags. It then adds and | |||
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Picking up where #218 was left off.