refactor backend SG provider #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
kishorj
added
the
tide/merge-method-squash
k8s-ci-robot
added
size/XXL
johngmyers
reviewed
Jan 3, 2023
k8s-ci-robot
added
the
needs-rebase
kishorj
force-pushed
the
sgprovier-refactor
branch
from
16ead21 to
d3cd9f7
Compare
k8s-ci-robot
removed
the
needs-rebase
M00nF1sh
reviewed
Apr 5, 2023
M00nF1sh
reviewed
Apr 5, 2023
kishorj
force-pushed
the
sgprovier-refactor
branch
from
d3cd9f7 to
0eb1664
Compare
M00nF1sh
reviewed
Apr 21, 2023
M00nF1sh
reviewed
Apr 21, 2023
M00nF1sh
reviewed
Apr 21, 2023
M00nF1sh
reviewed
Apr 21, 2023
| return true, errors.Wrapf(err, "unable to list ingresses") | ||
| } | ||
| for _, ing := range ingList.Items { | ||
| if !p.checkIngressFinalizersFunc(ing.GetFinalizers()) { |
There was a problem hiding this comment.
wondering whether there could be race conditions.
M00nF1sh
approved these changes
Apr 21, 2023
k8s-ci-robot
added
the
lgtm
|
/retest |
k8s-ci-robot
removed
the
lgtm
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2836 +/- ##
==========================================
+ Coverage 54.73% 55.05% +0.31%
==========================================
Files 145 148 +3
Lines 8479 8532 +53
==========================================
+ Hits 4641 4697 +56
- Misses 3503 3505 +2
+ Partials 335 330 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
M00nF1sh
reviewed
Apr 24, 2023
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, M00nF1sh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Refactor SG provider modules
Description
The controller currently cleans up auto-allocated backend SG only if there are no active ingress resources managed by the controller. This change causes the lb controller to delete the backend SG as soon as there are no active ingresses requiring automatic SG rules configuration. Also refactor the SG resolver code from the model builder.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯