-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove policy/v1beta1 since the min supported k8s version supports policy/v1 #3230
Conversation
|
Welcome @rdrgmnzs! |
Hi @rdrgmnzs. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
73c768d
to
5268e57
Compare
I don't see how this "fixes" the check, but it does make it easier to tell /ok-to-test |
policy/v1 is available since k8s 1.21. The min version we support with the latest release v2.5.x is k8s 1.22 or later. We can remove the policy/v1beta1 completely from the helm template. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #3230 +/- ##
=======================================
Coverage 54.70% 54.70%
=======================================
Files 148 148
Lines 8590 8590
=======================================
Hits 4699 4699
Misses 3559 3559
Partials 332 332 ☔ View full report in Codecov by Sentry. |
/lgtm cancel |
5268e57
to
d957ee6
Compare
Ok, went ahead and removed the conditional so we explicitly rely on policy/v1. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kishorj, rdrgmnzs The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Remove policy/v1beta1 since as of version 2.5.x the min supported k8s version 1.22 supports policy/v1.
Checklist
README.md
, or thedocs
directory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯