Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

udpate prow script to install lbc via manifest for ADC #3355

Merged
merged 2 commits into from
Aug 24, 2023
Merged

udpate prow script to install lbc via manifest for ADC #3355

merged 2 commits into from
Aug 24, 2023

Conversation

oliviassss
Copy link
Collaborator

Issue

Description

Update prow script for internal CI jobs running in ADC

  • install the controller via manifest
  • disable the NLB SG in ADC
  • upload YAML files for cert-manager and the controller. For cert-manager the images will be pull from ADC ECRs

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from M00nF1sh August 22, 2023 21:11
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 22, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (4c00e46) 55.61% compared to head (d048f76) 55.61%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3355   +/-   ##
=======================================
  Coverage   55.61%   55.61%           
=======================================
  Files         149      149           
  Lines        8819     8819           
=======================================
  Hits         4905     4905           
  Misses       3577     3577           
  Partials      337      337

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

M00nF1sh
M00nF1sh approved these changes Aug 22, 2023
View reviewed changes
Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, oliviassss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2023
@oliviassss
Copy link
Collaborator Author

Hold until some internal pipeline finishes
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2023
@johngmyers
Copy link
Contributor

Perhaps somewhere under tests/e2e would be better than docs/install/prow? Those manifests appear to be test-specific, not intended for end-user documentation.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 23, 2023
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@oliviassss
Copy link
Collaborator Author

@johngmyers, good point, I have moved them to test/

@oliviassss oliviassss added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 23, 2023
@oliviassss oliviassss merged commit 55ddccb into kubernetes-sigs:main Aug 24, 2023
@oliviassss oliviassss deleted the script-update branch August 28, 2023 22:36
johngmyers pushed a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Feb 6, 2024
@oliviassss @johngmyers
udpate prow script to install lbc via manifest for ADC (kubernetes-si…
5bcc4a9 
…gs#3355)

* udpate prow script to install lbc via manifest for ADC

* move yaml files to test dir
@M00nF1sh M00nF1sh mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M00nF1sh M00nF1sh M00nF1sh approved these changes

@johngmyers johngmyers Awaiting requested review from johngmyers

Assignees

@M00nF1sh M00nF1sh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oliviassss @codecov-commenter @k8s-ci-robot @johngmyers @M00nF1sh