Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary patch requests #3380

Merged
merged 1 commit into from
Sep 11, 2023
Merged

remove unnecessary patch requests #3380

merged 1 commit into from
Sep 11, 2023

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Sep 8, 2023

Description

Cherry-pick #3373 into release-2.6 branch

-->

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 93.33% and project coverage change: +0.03% 🎉

Comparison is base (db7416e) 55.61% compared to head (0baec9b) 55.64%.

Additional details and impacted files 
@@               Coverage Diff               @@
##           release-2.6    #3380      +/-   ##
===============================================
+ Coverage        55.61%   55.64%   +0.03%     
===============================================
  Files              149      149              
  Lines             8819     8807      -12     
===============================================
- Hits              4905     4901       -4     
+ Misses            3577     3573       -4     
+ Partials           337      333       -4
Files Changed Coverage Δ
pkg/targetgroupbinding/resource_manager.go 14.38% <93.33%> (-0.79%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oliviassss
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@oliviassss
Copy link
Collaborator

/retest

@k8s-ci-robot
Copy link
Contributor

@M00nF1sh: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-load-balancer-controller-e2e-test 0baec9b link true /test pull-aws-load-balancer-controller-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@M00nF1sh
Copy link
Collaborator Author

M00nF1sh commented Sep 11, 2023 •
edited
Loading

/test pull-aws-load-balancer-controller-e2e-test

@M00nF1sh M00nF1sh merged commit 5a5885b into kubernetes-sigs:release-2.6 Sep 11, 2023
@M00nF1sh M00nF1sh deleted the release-2.6 branch September 11, 2023 16:57
johngmyers pushed a commit to johngmyers/aws-load-balancer-controller that referenced this pull request Feb 6, 2024
Pull request kubernetes-sigs#7: IENGOC-39: Remediate http/2 vulnerabi…
a622844 
…lity

Merge in DEL/aws-load-balancer-controller-fork from IENGOC-39 to main

* commit '3e26f86e82a5d419a7f8adfc5c95dd45984be6f4':
  IENGOC-39: Remediate more bd vulnerabilities
  IENGOC-39: Remediate bd vulnerabilities
  cut v2.6.2 release (kubernetes-sigs#3453)
  update ci e2e script for cert IDs (kubernetes-sigs#3392)
  fix test failure
  doc updates (kubernetes-sigs#3426)
  Change of text "your-cluster-name" (kubernetes-sigs#3152)
  slice init style suggestion
  whitespace
  group errors, emit one event per reconcile, requeue on failure
  don't block TGB reconciliation loop on failed SG ingress reconciliation
  fix: remove service from function args
  feat: resolve health check port name for NLB
  Expose ingress configuration options for missing backends (kubernetes-sigs#3342)
  Stricter dependency/security review
  remove unnecessary patch requests (kubernetes-sigs#3380)
  increase timeout to 2h in ci scripts
  wait for the TG to be healthy before cleanup any resource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johngmyers johngmyers Awaiting requested review from johngmyers

@oliviassss oliviassss Awaiting requested review from oliviassss

Assignees

@oliviassss oliviassss

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@M00nF1sh @k8s-ci-robot @codecov-commenter @oliviassss