Repo controlled build go version #3598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3598 +/- ##
===========================================
+ Coverage 17.83% 55.31% +37.47%
===========================================
Files 175 149 -26
Lines 29046 8978 -20068
===========================================
- Hits 5180 4966 -214
+ Misses 23527 3673 -19854
Partials 339 339 ☔ View full report in Codecov by Sentry. |
k8s-ci-robot
added
size/XXL
|
Upgrading helm version to v3.14.2 led to issues, I suspect it's the controller-runtime version too old (currently we are on v0.14.16), but the v0.15+ has some breaking changes, we may need code implementation in LBC. I will investigate this issue and fix later. |
6 tasks
k8s-ci-robot
added
size/S
oliviassss
added
the
tide/merge-method-squash
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oliviassss, xdu31 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
shraddhabang
pushed a commit
to shraddhabang/aws-load-balancer-controller
that referenced
this pull request
Mar 20, 2024
M00nF1sh
pushed a commit
that referenced
this pull request
Mar 22, 2024
* fix log level in listener manager and tagging manager (#3573) * bump up controller-gen version and update manifests (#3580) * docs: ingress subnets annotation - clarify locale differences (#3579) * feat: allowed ACM cert discovery to filter on CA ARNs (#3565) (#3591) * Add example for NLB target-group-attributes to enable unhealthy target connection draining (#3577) * Add example annotation for NLB unhealthy target connection draining * Add emtpyline back in * fix: ca-filter causing expontentially more api-calls (#3608) due to missing cache * Repo controlled build go version (#3598) * update go version to mitigate CVE (#3615) * Adding support for Availability Zone Affinity (#3470) Fixes #3431 Signed-off-by: Alex Berger <[email protected]> * Update golang.org/protobuf version to fix CVE-2024-24786 (#3618) * Add a note to recommend to use compatible chart and image versions * Update golang.org/protobuf version to fix CVE-2024-24786 --------- Signed-off-by: Alex Berger <[email protected]> Co-authored-by: Olivia Song <[email protected]> Co-authored-by: Andrey Lebedev <[email protected]> Co-authored-by: Nathanael Liechti <[email protected]> Co-authored-by: Isaac Wilson <[email protected]> Co-authored-by: Nathanael Liechti <[email protected]> Co-authored-by: Jason Du <[email protected]> Co-authored-by: Hao Zhou <[email protected]> Co-authored-by: Alexander Berger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Description
Repo controlled Go version, follow kubernetes/enhancements#3744 to make aws-load-balancer-controller to stay on supported Go versions.
This PR follows kubernetes/kubernetes#114660 and kubernetes/kubernetes#115377 for repo-controlled go version to use in CI.
Checklist
README.md, or thedocsdirectory)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯