Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cut v1.0.0 release #738

Merged
merged 1 commit into from
Nov 16, 2018
Merged

cut v1.0.0 release #738

merged 1 commit into from
Nov 16, 2018

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Nov 16, 2018

  1. Cutting v1.0.0 release(we decided to change to use semantic version to align with go community)
  2. Change default force sync time to 60 minutes(from 30 seconds)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 16, 2018
@bigkraig
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2018
@k8s-ci-robot k8s-ci-robot merged commit 8115b25 into kubernetes-sigs:master Nov 16, 2018
@rifelpet
Copy link
Contributor

@M00nF1sh can we include the docker image in the Release assets?

@M00nF1sh
Copy link
Collaborator Author

@rifelpet
nice suggestion! do you mean adding links to release note(like quay.io/coreos/alb-ingress-controller:v1.0.0), or attach the image as a file? 😄

@rifelpet
Copy link
Contributor

Just the quay.io url would be sufficient. Have we considered hosting the image on ECR?

@M00nF1sh
Copy link
Collaborator Author

We can host our image in ECR, but currently there is an accountID in ECR endpoints 😞 .

Instead I have started an internal process to able to host our image in https://hub.docker.com/u/amazon/

@M00nF1sh M00nF1sh deleted the v1.0.0 branch December 7, 2018 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants