Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support aznfs mount helper #987

Merged
merged 9 commits into from
Sep 4, 2023
Merged

feat: support aznfs mount helper #987

merged 9 commits into from
Sep 4, 2023

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Aug 2, 2023 •
edited
Loading

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support aznfs mount helper
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

We can check whether the migration happens by taking a look at the logs on host path /opt/microsoft/aznfs/data/aznfs.log

image

Release note:

feat: support mounting by [aznfs mount helper](https://github.com/Azure/AZNFS-mount/)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 2, 2023
@cvvz cvvz changed the title [WIP] support aznfs feat: support aznfs mount helper Aug 2, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2023
andyzhangx
andyzhangx reviewed Aug 2, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2023
andyzhangx
andyzhangx reviewed Aug 3, 2023
View reviewed changes
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 3, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 16, 2023
andyzhangx
andyzhangx reviewed Aug 17, 2023
View reviewed changes
andyzhangx
andyzhangx reviewed Aug 17, 2023
View reviewed changes
@cvvz
Copy link
Member Author

cvvz commented Aug 17, 2023

/retest

@cvvz
Squashed commit of the following:
0f30f6e 
commit 408353f
Merge: d57e587 3465228
Author: weizhichen <[email protected]>
Date:   Thu Aug 17 09:55:54 2023 +0000

    Merge branch 'master' of https://github.com/kubernetes-sigs/blob-csi-driver into support-aznfs

commit d57e587
Author: weizhichen <[email protected]>
Date:   Thu Aug 17 09:23:31 2023 +0000

    fix

commit 3148e86
Author: weizhichen <[email protected]>
Date:   Thu Aug 17 09:18:54 2023 +0000

    fix

commit 8036bf2
Author: weizhichen <[email protected]>
Date:   Thu Aug 17 09:13:14 2023 +0000

    Revert "support arm64"

    This reverts commit b5c9bfd.

commit b3f9a6c
Author: weizhichen <[email protected]>
Date:   Wed Aug 16 15:06:48 2023 +0000

    fix

commit b5c9bfd
Author: weizhichen <[email protected]>
Date:   Wed Aug 16 03:33:38 2023 +0000

    support arm64

commit 917c1f6
Author: weizhichen <[email protected]>
Date:   Wed Aug 9 09:10:27 2023 +0000

    official release

commit 783cdaf
Author: weizhichen <[email protected]>
Date:   Fri Aug 4 04:08:12 2023 +0000

    fix

commit 9c1d08a
Author: weizhichen <[email protected]>
Date:   Fri Aug 4 03:07:13 2023 +0000

    fix

commit c8e5015
Author: weizhichen <[email protected]>
Date:   Thu Aug 3 08:33:16 2023 +0000

    fix

commit 9747128
Merge: 57a1407 cc884d5
Author: weizhichen <[email protected]>
Date:   Thu Aug 3 08:31:48 2023 +0000

    Merge branch 'master' of https://github.com/kubernetes-sigs/blob-csi-driver into support-aznfs

commit 57a1407
Author: weizhichen <[email protected]>
Date:   Thu Aug 3 08:05:38 2023 +0000

    fix

commit 8f262b2
Author: weizhichen <[email protected]>
Date:   Wed Aug 2 08:07:54 2023 +0000

    fix

commit 78808c3
Author: weizhichen <[email protected]>
Date:   Wed Aug 2 08:06:04 2023 +0000

    fix

commit 833dde7
Author: weizhichen <[email protected]>
Date:   Wed Aug 2 07:56:17 2023 +0000

    fix

commit d6d6de2
Author: weizhichen <[email protected]>
Date:   Wed Aug 2 02:39:04 2023 +0000

    POC
andyzhangx
andyzhangx reviewed Aug 21, 2023
View reviewed changes
@cvvz
Copy link
Member Author

cvvz commented Aug 24, 2023

/retest

andyzhangx
andyzhangx approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 4, 2023
@andyzhangx
Copy link
Member

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 4, 2023
@andyzhangx andyzhangx merged commit 3317389 into kubernetes-sigs:master Sep 4, 2023
@andyzhangx
Copy link
Member

/cherrypick release-1.22

@k8s-infra-cherrypick-robot
Copy link

@andyzhangx: #987 failed to apply on top of branch "release-1.22":

Applying: Squashed commit of the following:
.git/rebase-apply/patch:463: trailing whitespace.
    
.git/rebase-apply/patch:477: trailing whitespace.
    
.git/rebase-apply/patch:478: trailing whitespace.
    # when running dpkg -i /etc/packages-microsoft-prod.deb, need to enter y to continue. 
warning: 3 lines add whitespace errors.
warning: Cannot merge binary files: charts/latest/blob-csi-driver-v0.0.0.tgz (HEAD vs. Squashed commit of the following:)
Using index info to reconstruct a base tree...
M	Makefile
M	charts/latest/blob-csi-driver-v0.0.0.tgz
M	charts/latest/blob-csi-driver/values.yaml
Falling back to patching base and 3-way merge...
Auto-merging charts/latest/blob-csi-driver/values.yaml
Auto-merging charts/latest/blob-csi-driver-v0.0.0.tgz
CONFLICT (content): Merge conflict in charts/latest/blob-csi-driver-v0.0.0.tgz
Auto-merging Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Squashed commit of the following:
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

cvvz added a commit to cvvz/blob-csi-driver that referenced this pull request Sep 5, 2023
@cvvz
feat: support aznfs mount helper (kubernetes-sigs#987)
e91edda 
* Squashed commit of the following:

commit 408353f
Merge: d57e587 3465228
Author: weizhichen <[email protected]>
Date:   Thu Aug 17 09:55:54 2023 +0000

    Merge branch 'master' of https://github.com/kubernetes-sigs/blob-csi-driver into support-aznfs

commit d57e587
Author: weizhichen <[email protected]>
Date:   Thu Aug 17 09:23:31 2023 +0000

    fix

commit 3148e86
Author: weizhichen <[email protected]>
Date:   Thu Aug 17 09:18:54 2023 +0000

    fix

commit 8036bf2
Author: weizhichen <[email protected]>
Date:   Thu Aug 17 09:13:14 2023 +0000

    Revert "support arm64"

    This reverts commit b5c9bfd.

commit b3f9a6c
Author: weizhichen <[email protected]>
Date:   Wed Aug 16 15:06:48 2023 +0000

    fix

commit b5c9bfd
Author: weizhichen <[email protected]>
Date:   Wed Aug 16 03:33:38 2023 +0000

    support arm64

commit 917c1f6
Author: weizhichen <[email protected]>
Date:   Wed Aug 9 09:10:27 2023 +0000

    official release

commit 783cdaf
Author: weizhichen <[email protected]>
Date:   Fri Aug 4 04:08:12 2023 +0000

    fix

commit 9c1d08a
Author: weizhichen <[email protected]>
Date:   Fri Aug 4 03:07:13 2023 +0000

    fix

commit c8e5015
Author: weizhichen <[email protected]>
Date:   Thu Aug 3 08:33:16 2023 +0000

    fix

commit 9747128
Merge: 57a1407 cc884d5
Author: weizhichen <[email protected]>
Date:   Thu Aug 3 08:31:48 2023 +0000

    Merge branch 'master' of https://github.com/kubernetes-sigs/blob-csi-driver into support-aznfs

commit 57a1407
Author: weizhichen <[email protected]>
Date:   Thu Aug 3 08:05:38 2023 +0000

    fix

commit 8f262b2
Author: weizhichen <[email protected]>
Date:   Wed Aug 2 08:07:54 2023 +0000

    fix

commit 78808c3
Author: weizhichen <[email protected]>
Date:   Wed Aug 2 08:06:04 2023 +0000

    fix

commit 833dde7
Author: weizhichen <[email protected]>
Date:   Wed Aug 2 07:56:17 2023 +0000

    fix

commit d6d6de2
Author: weizhichen <[email protected]>
Date:   Wed Aug 2 02:39:04 2023 +0000

    POC

* fix by review

* helm

* fix

* helm

* fix log panic

* fix

* fix

* fix
This was referenced Sep 5, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@ZeroMagic ZeroMagic Awaiting requested review from ZeroMagic

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cvvz @k8s-ci-robot @andyzhangx @k8s-infra-cherrypick-robot