Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: replacements to all array elements #240

Merged
merged 2 commits into from
Mar 24, 2022
Merged

docs: replacements to all array elements #240

merged 2 commits into from
Mar 24, 2022

Conversation

koba1t
Copy link
Member

@koba1t koba1t commented Feb 13, 2022

Add docs for replacements to all array elements. (PR merged: kubernetes-sigs/kustomize#4424)
Fix: kubernetes-sigs/kustomize#4053 (comment)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 13, 2022
@koba1t koba1t mentioned this pull request Feb 13, 2022
Closed
@KnVerey
Copy link
Contributor

KnVerey commented Feb 25, 2022

/assign @natasha41575

@natasha41575
Copy link
Contributor

Ah sorry for the late review; taking a look now!

natasha41575
natasha41575 reviewed Mar 1, 2022
View reviewed changes
site/content/en/references/kustomize/kustomization/replacements/_index.md Outdated
@@ -198,10 +198,14 @@ Strings are used for mapping nodes. For sequence nodes, we support two options:

2. Index by key-value pair: `spec.template.spec.containers.[name=nginx].image`

And, Wildcard( `*` ) is replacing every element.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
And, Wildcard( `*` ) is replacing every element.
3. Index with a wildcard match: `spec.template.spec.containers.*.env.[name=TARGET_ENV].value`. This will target every element in the list.

site/content/en/references/kustomize/kustomization/replacements/_index.md Outdated
@@ -198,10 +198,14 @@ Strings are used for mapping nodes. For sequence nodes, we support two options:

2. Index by key-value pair: `spec.template.spec.containers.[name=nginx].image`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a sentence here, e.g. If the key-value pair matches multiple elements in the sequence node, all matching elements will be targetted.

site/content/en/references/kustomize/kustomization/replacements/_index.md
@@ -198,10 +198,14 @@ Strings are used for mapping nodes. For sequence nodes, we support two options:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above it says "For sequence nodes, we support two options". This should say three, not two.

@koba1t
Copy link
Member Author

koba1t commented Mar 2, 2022

@natasha41575 Thanks for your review.
I fixed a few lines with your comments.

@natasha41575
Copy link
Contributor

/lgtm
/approve
/hold, until we release

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 2, 2022
@natasha41575
Copy link
Contributor

/label tide/merge-method-squash

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: koba1t, natasha41575

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 2, 2022
@natasha41575
Copy link
Contributor

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 2, 2022
@natasha41575
Copy link
Contributor

/hold cancel

@natasha41575
Copy link
Contributor

/retest

@natasha41575
Copy link
Contributor

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2022
@natasha41575
Copy link
Contributor

/retest

@natasha41575
Copy link
Contributor

/test all

@k8s-ci-robot
Copy link
Contributor

@natasha41575: No presubmit jobs available for kubernetes-sigs/cli-experimental@master

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit d80d0d9 into kubernetes-sigs:master Mar 24, 2022
@koba1t koba1t mentioned this pull request Jul 12, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natasha41575 natasha41575 natasha41575 left review comments

@Liujingfang1 Liujingfang1 Awaiting requested review from Liujingfang1

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@natasha41575 natasha41575

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow setting every array element in replacements
4 participants
@koba1t @KnVerey @natasha41575 @k8s-ci-robot