add filter parameter in list function of fileshare client (#7888)

kubernetes-sigs · Dec 23, 2024 · 27216aa · 27216aa
1 parent 4d2680e
commit 27216aa
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 12 deletions.
diff --git a/pkg/azclient/fileshareclient/custom.go b/pkg/azclient/fileshareclient/custom.go
@@ -54,14 +54,12 @@ func (client *Client) Delete(ctx context.Context, resourceGroupName string, pare
 const ListOperationName = "FileSharesClient.List"
 
 // List gets a list of FileShare in the resource group.
-func (client *Client) List(ctx context.Context, resourceGroupName string, accountName string, expand *string) (result []*armstorage.FileShareItem, err error) {
+func (client *Client) List(ctx context.Context, resourceGroupName string, accountName string, option *armstorage.FileSharesClientListOptions) (result []*armstorage.FileShareItem, err error) {
 	metricsCtx := metrics.BeginARMRequest(client.subscriptionID, resourceGroupName, "FileShare", "list")
 	defer func() { metricsCtx.Observe(ctx, err) }()
 	ctx, endSpan := runtime.StartSpan(ctx, ListOperationName, client.tracer, nil)
 	defer endSpan(err)
-	pager := client.FileSharesClient.NewListPager(resourceGroupName, accountName, &armstorage.FileSharesClientListOptions{
-		Expand: expand,
-	})
+	pager := client.FileSharesClient.NewListPager(resourceGroupName, accountName, option)
 	for pager.More() {
 		nextResult, err := pager.NextPage(ctx)
 		if err != nil {

diff --git a/pkg/azclient/fileshareclient/custom_test.go b/pkg/azclient/fileshareclient/custom_test.go
diff --git a/pkg/azclient/fileshareclient/interface.go b/pkg/azclient/fileshareclient/interface.go
@@ -28,7 +28,7 @@ import (
 // +azure:client:verbs=get,resource=Account,subResource=FileShare,packageName=github.com/Azure/azure-sdk-for-go/sdk/resourcemanager/storage/armstorage,packageAlias=armstorage,clientName=FileSharesClient,expand=false,crossSubFactory=true
 type Interface interface {
 	utils.SubResourceGetFunc[armstorage.FileShare]
-	List(ctx context.Context, resourceGroupName string, accountName string, expand *string) (result []*armstorage.FileShareItem, err error)
+	List(ctx context.Context, resourceGroupName string, accountName string, option *armstorage.FileSharesClientListOptions) (result []*armstorage.FileShareItem, err error)
 	Create(ctx context.Context, resourceGroupName string, resourceName string, parentResourceName string, resource armstorage.FileShare, expand *string) (*armstorage.FileShare, error)
 	Update(ctx context.Context, resourceGroupName string, resourceName string, parentResourceName string, resource armstorage.FileShare) (*armstorage.FileShare, error)
 	Delete(ctx context.Context, resourceGroupName string, parentResourceName string, resourceName string, expand *string) error

diff --git a/pkg/azclient/fileshareclient/mock_fileshareclient/interface.go b/pkg/azclient/fileshareclient/mock_fileshareclient/interface.go