Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Kubernetes vendor to v1.17.0 #269

Merged
merged 2 commits into from
Dec 17, 2019
Merged

Upgrade Kubernetes vendor to v1.17.0 #269

merged 2 commits into from
Dec 17, 2019

Conversation

chewong
Copy link
Member

@chewong chewong commented Dec 11, 2019 •
edited
Loading

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change
/kind bug
/kind cleanup
/kind design
/kind documentation
/kind failing-test
/kind feature
/kind flake

What this PR does / why we need it:

/assign @feiskyer

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Release note:

Upgrade Kubernetes vendor to v1.17.0

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 11, 2019
@chewong
Copy link
Member Author

chewong commented Dec 11, 2019

/test pull-cloud-provider-azure-e2e

@chewong
Copy link
Member Author

chewong commented Dec 11, 2019

/hold
e2e tests are still testing on k8s release-1.16 branch.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 11, 2019
@feiskyer
Copy link
Member

New release of cloud-provider-azure is pending on this. @chewong let's merge the PR and update test-infra jobs in a following PR?

@chewong
Copy link
Member Author

chewong commented Dec 16, 2019

Sounds good.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2019
feiskyer
feiskyer reviewed Dec 17, 2019
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chewong, feiskyer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2019
@feiskyer feiskyer added the area/provider/azure Issues or PRs related to azure provider label Dec 17, 2019
@chewong
Copy link
Member Author

chewong commented Dec 17, 2019

/test pull-cloud-provider-azure-e2e

@k8s-ci-robot k8s-ci-robot merged commit 5ac9a2a into kubernetes-sigs:master Dec 17, 2019
@chewong chewong deleted the k8s-1-17 branch December 17, 2019 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer feiskyer left review comments

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@ritazh ritazh Awaiting requested review from ritazh

Assignees

@feiskyer feiskyer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/azure Issues or PRs related to azure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chewong @feiskyer @k8s-ci-robot