Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Fix incorrect order of Node internal address issue #3643

Closed
wants to merge 1 commit into from
Closed

[WIP] Fix incorrect order of Node internal address issue #3643

wants to merge 1 commit into from

Conversation

lzhecheng
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix incorrect order of Node internal address issue. getLocalInstanceNodeAddresses() always returns IPv4 then IPv6 if Node is dual-stack. The order of 2 internal IPs should be consistent as when first IP is added to the Node.

Which issue(s) this PR fixes:

Fixes #3401

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fix incorrect order of Node internal address issue. getLocalInstanceNodeAddresses() always returns IPv4 then IPv6 if Node is dual-stack. The order of 2 internal IPs should be consistent as when first IP is added to the Node.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 24, 2023
@netlify
Copy link

netlify bot commented Mar 24, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cloud-provide-azure canceled.

Name Link
🔨 Latest commit a2758f6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cloud-provide-azure/deploys/641daaf0c5cabb0008b2e5a4

@k8s-ci-robot k8s-ci-robot requested a review from feiskyer March 24, 2023 11:58
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from jwtty March 24, 2023 11:58
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 24, 2023
@lzhecheng
Copy link
Contributor Author

/hold wait for confirmation from capz

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 24, 2023
@lzhecheng lzhecheng mentioned this pull request Mar 24, 2023
Closed
@lzhecheng lzhecheng force-pushed the fix-node-addr-order branch from cdd5003 to f5d7cdd Compare March 24, 2023 12:13
@coveralls
Copy link

coveralls commented Mar 24, 2023 •
edited
Loading

Coverage Status

Coverage: 79.61% (+0.03%) from 79.585% when pulling a2758f6 on lzhecheng:fix-node-addr-order into 3cf1f0d on kubernetes-sigs:master.

@lzhecheng
Fix incorrect order of Node internal address issue
a2758f6 
getLocalInstanceNodeAddresses() always returns IPv4 then IPv6
if Node is dual-stack. The order of 2 internal IPs should be
consistent as when first IP is added to the Node.

Signed-off-by: Zhecheng Li <[email protected]>
@lzhecheng lzhecheng force-pushed the fix-node-addr-order branch from f5d7cdd to a2758f6 Compare March 24, 2023 13:51
@lzhecheng lzhecheng changed the title Fix incorrect order of Node internal address issue [WIP] Fix incorrect order of Node internal address issue Mar 29, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2023
@lzhecheng
Copy link
Contributor Author

/close
This PR is not needed. IPv4 first and then IPv6 is the expected behavior from CAPZ side.
Detail: #3401 (comment)

@k8s-ci-robot
Copy link
Contributor

@lzhecheng: Closed this PR.

In response to this:

/close
This PR is not needed. IPv4 first and then IPv6 is the expected behavior from CAPZ side.
Detail: #3401 (comment)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@lzhecheng lzhecheng deleted the fix-node-addr-order branch March 30, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@jwtty jwtty Awaiting requested review from jwtty

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipv6 + Calico + out of tree cloud-provider is broken
3 participants
@lzhecheng @k8s-ci-robot @coveralls