-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored codebase to use camel case for spec parameter in field.NewPath method #4878
Conversation
Hi @lakshkeswani. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for opening this PR and working on this! Make sure to set the release note to "NONE" and sign the CNCF CLA. Also, whenever this PR is ready for review, please convert it from a draft PR to a normal PR!
Left a few comments on some nits and minor things that were missed.
/ok-to-test |
/ok-to-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few more changes! Also, don't forget to squash your commits once you've made all the changes.
@willie-yao I have resolved the comments have a look and i will squash the commits once i get go ahead from you. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/assign @mboersma
Thanks for your work and patience on this! 🚀
LGTM label has been added. Git tree hash: 696bbef3cdbb21c04bbec6c21a4096d453e1eb1a
|
/hold for squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/label tide/merge-method-squash
/hold cancel
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4878 +/- ##
==========================================
- Coverage 62.19% 62.18% -0.02%
==========================================
Files 201 201
Lines 16878 16878
==========================================
- Hits 10497 10495 -2
- Misses 5591 5593 +2
Partials 790 790 ☔ View full report in Codecov by Sentry. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes
Fixes #4862
Special notes for your reviewer:
TODOs:
Release note: