-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop Local only env var #4998
drop Local only env var #4998
Conversation
Skipping CI for Draft Pull Request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 60f6b749593a366ab73365176555e6fb0c3318bf
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4998 +/- ##
=======================================
Coverage 51.18% 51.18%
=======================================
Files 274 274
Lines 24625 24625
=======================================
Hits 12605 12605
Misses 11234 11234
Partials 786 786 ☔ View full report in Codecov by Sentry. |
/lgtm should we remove all of the references and comments in test-infra jobs? |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
/test pull-cluster-api-provider-azure-e2e |
1 similar comment
/test pull-cluster-api-provider-azure-e2e |
/test pull-cluster-api-provider-azure-e2e |
/lgtm |
LGTM label has been added. Git tree hash: 234e22b458b72bb7bc23c78fe2f7732e8eb2b551
|
/retest |
@nawazkh: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
LOCAL_ONLY
from the test scripts. We dont seem to be using it anymore, so cleaning it up.LOCAL_ONLY
I have defaultedUSE_LOCAL_KIND_REGISTRY
totrue
as it would be behaved withLOCAL_ONLY
being present.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Special notes for your reviewer:
TODOs:
Release note: