Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop Local only env var #4998

Merged
merged 1 commit into from
Jul 23, 2024
Merged

Conversation

nawazkh
Copy link
Member

@nawazkh nawazkh commented Jul 17, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

  • This PR drops the env variable LOCAL_ONLY from the test scripts. We dont seem to be using it anymore, so cleaning it up.
  • By dropping LOCAL_ONLY I have defaulted USE_LOCAL_KIND_REGISTRY to true as it would be behaved with LOCAL_ONLY being present.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Special notes for your reviewer:

  • cherry-pick candidate

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Drop LOCAL_ONLY env var from the test scripts.

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 17, 2024
@k8s-ci-robot k8s-ci-robot requested review from Jont828 and marosset July 17, 2024 23:37
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 17, 2024
Copy link
Contributor

@jsturtevant jsturtevant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 17, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 60f6b749593a366ab73365176555e6fb0c3318bf

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.18%. Comparing base (0dee597) to head (851b93d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4998   +/-   ##
=======================================
  Coverage   51.18%   51.18%           
=======================================
  Files         274      274           
  Lines       24625    24625           
=======================================
  Hits        12605    12605           
  Misses      11234    11234           
  Partials      786      786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nawazkh nawazkh marked this pull request as ready for review July 18, 2024 18:09
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 18, 2024
@k8s-ci-robot k8s-ci-robot requested review from mboersma and nojnhuh July 18, 2024 18:09
@jackfrancis
Copy link
Contributor

/lgtm
/approve

should we remove all of the references and comments in test-infra jobs?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 18, 2024
@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 22, 2024

/retest

1 similar comment
@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 22, 2024

/retest

@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 22, 2024

/test pull-cluster-api-provider-azure-e2e

1 similar comment
@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 22, 2024

/test pull-cluster-api-provider-azure-e2e

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2024
@k8s-ci-robot k8s-ci-robot requested a review from jackfrancis July 22, 2024 22:02
@k8s-ci-robot k8s-ci-robot requested a review from jsturtevant July 22, 2024 22:02
@nawazkh
Copy link
Member Author

nawazkh commented Jul 22, 2024

/test pull-cluster-api-provider-azure-e2e

@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 22, 2024

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 234e22b458b72bb7bc23c78fe2f7732e8eb2b551

@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 22, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 23, 2024

@nawazkh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-conformance 851b93d link false /test pull-cluster-api-provider-azure-conformance
pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts 851b93d link false /test pull-cluster-api-provider-azure-conformance-dual-stack-with-ci-artifacts
pull-cluster-api-provider-azure-conformance-custom-builds 851b93d link false /test pull-cluster-api-provider-azure-conformance-custom-builds
pull-cluster-api-provider-azure-capi-e2e 851b93d link false /test pull-cluster-api-provider-azure-capi-e2e
pull-cluster-api-provider-azure-windows-custom-builds 851b93d link false /test pull-cluster-api-provider-azure-windows-custom-builds
pull-cluster-api-provider-azure-windows-with-ci-artifacts 851b93d link false /test pull-cluster-api-provider-azure-windows-with-ci-artifacts

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot merged commit e40af9e into kubernetes-sigs:main Jul 23, 2024
21 of 27 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.17 milestone Jul 23, 2024
@nawazkh nawazkh deleted the drop_local_only branch January 17, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants