Migrate gometalinter to golangci lint #138
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/assign @xmudrii |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: joonas The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/XL
added 2 commits
November 22, 2019 17:46
k8s-ci-robot
added
size/L
xmudrii
reviewed
Nov 25, 2019
| @@ -0,0 +1,17 @@ | |||
| run: | |||
| concurrency: 2 | |||
There was a problem hiding this comment.
What is the default behavior, i.e. when we don't specify concurrency?
Comment on lines
+11
to
+17
| - vet | ||
| - golint | ||
| - varcheck | ||
| - structcheck | ||
| - gosimple | ||
| - unused | ||
| - errcheck |
There was a problem hiding this comment.
Looking at other CAPI projects, they enable a bit more linters. Is it possible to enable those here too?
| @@ -0,0 +1,5 @@ | |||
| module sigs.k8s.io/cluster-api-provider-digitalocean/hack/tools | |||
|
Closing this PR in favor of #140. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
gometalinterhas been deprecated, andgolangci-lintis the recommended replacement.This replaces
gometalinterwithgolangci-lint.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Documentation:
Release note: