-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃Remove most uses of submakes in Makefile #1040
Conversation
✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready! 🔨 Explore the source changes: 0b2df35 🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61851e580d631300082e1b17 😎 Browse the preview: https://deploy-preview-1040--kubernetes-sigs-cluster-api-openstack.netlify.app |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test pull-cluster-api-provider-openstack-e2e-test |
does this conflict to #1039 ? |
This is just a WIP PR and should not be merged, see #1039 (comment) @mdbooth you can add the WIP label in such cases
|
/retitle WIP Remove .EXPORT_ALL_VARIABLES |
/lgtm This is more readable too IMO |
I think it's a great PR |
/lgtm |
Seems like there's some agreement to merge this. /hold cancel |
I look back again this PR due to time has passed. I take a look at CAPA and found our current Makefile is like CAPA. I am not familiar with Makefile so that I want to continue to refer to Makefile in CAPA as of now. /lgtm cancel |
That's entirely reasonable, and I also didn't feel confident pushing it due to the lack of test coverage. I'll drop this. |
What this PR does / why we need it:
This commit series systematically removes most uses of submakes in the top level Makefile. It was fairly easy to write and I personally think it results in a more maintainable Makefile.
HOWEVER, I'm not aware of any bugs it addresses (yet), there's obviously the possibility that it has introduced bugs, and we don't have great test coverage of the Makefile, so... is it worth it?
/hold