Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏃Remove most uses of submakes in Makefile #1040

Closed
wants to merge 14 commits into from

Conversation

mdbooth
Copy link
Contributor

@mdbooth mdbooth commented Nov 4, 2021

What this PR does / why we need it:
This commit series systematically removes most uses of submakes in the top level Makefile. It was fairly easy to write and I personally think it results in a more maintainable Makefile.

HOWEVER, I'm not aware of any bugs it addresses (yet), there's obviously the possibility that it has introduced bugs, and we don't have great test coverage of the Makefile, so... is it worth it?

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 4, 2021
@netlify
Copy link

netlify bot commented Nov 4, 2021

✔️ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

🔨 Explore the source changes: 0b2df35

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/61851e580d631300082e1b17

😎 Browse the preview: https://deploy-preview-1040--kubernetes-sigs-cluster-api-openstack.netlify.app

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mdbooth
To complete the pull request process, please assign hidekazuna after the PR has been reviewed.
You can assign the PR to them by writing /assign @hidekazuna in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 4, 2021
@jichenjc
Copy link
Contributor

jichenjc commented Nov 5, 2021

/test pull-cluster-api-provider-openstack-e2e-test

@jichenjc
Copy link
Contributor

jichenjc commented Nov 5, 2021

does this conflict to #1039 ?

@tobiasgiese
Copy link
Member

tobiasgiese commented Nov 5, 2021

does this conflict to #1039 ?

This is just a WIP PR and should not be merged, see #1039 (comment)

@mdbooth you can add the WIP label in such cases

/title WIP Remove .EXPORT_ALL_VARIABLES

@tobiasgiese
Copy link
Member

/retitle WIP Remove .EXPORT_ALL_VARIABLES

@k8s-ci-robot k8s-ci-robot changed the title Remove .EXPORT_ALL_VARIABLES WIP Remove .EXPORT_ALL_VARIABLES Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2021
@k8s-ci-robot k8s-ci-robot removed the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 5, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 5, 2021
@mdbooth mdbooth changed the title WIP Remove .EXPORT_ALL_VARIABLES Remove most uses of submakes in Makefile Nov 5, 2021
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 5, 2021
@mdbooth mdbooth changed the title Remove most uses of submakes in Makefile 🐛Remove most uses of submakes in Makefile Nov 5, 2021
@mdbooth mdbooth changed the title 🐛Remove most uses of submakes in Makefile 🏃Remove most uses of submakes in Makefile Nov 5, 2021
@iamemilio
Copy link
Contributor

/lgtm

This is more readable too IMO

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2021
@jichenjc
Copy link
Contributor

jichenjc commented Nov 9, 2021

I think it's a great PR
the question I am having is as commit msg said, how to test those ..
if we are sure current test is good enough and overtime we can add more test to cover those newly added rules, I can live with that, just need some agreement .. thanks

@hidekazuna
Copy link
Contributor

/lgtm

@mdbooth
Copy link
Contributor Author

mdbooth commented Nov 19, 2021

Seems like there's some agreement to merge this.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2021
@hidekazuna
Copy link
Contributor

I look back again this PR due to time has passed. I take a look at CAPA and found our current Makefile is like CAPA. I am not familiar with Makefile so that I want to continue to refer to Makefile in CAPA as of now.

/lgtm cancel

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 8, 2021
@mdbooth
Copy link
Contributor Author

mdbooth commented Dec 8, 2021

I look back again this PR due to time has passed. I take a look at CAPA and found our current Makefile is like CAPA. I am not familiar with Makefile so that I want to continue to refer to Makefile in CAPA as of now.

/lgtm cancel

That's entirely reasonable, and I also didn't feel confident pushing it due to the lack of test coverage. I'll drop this.

@mdbooth mdbooth closed this Dec 8, 2021
@mdbooth mdbooth deleted the makefile branch April 6, 2022 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants