Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin GitHub actions to commit SHAs #7466

Closed
sbueringer opened this issue Oct 31, 2022 · 5 comments · Fixed by #7502
Closed

Pin GitHub actions to commit SHAs #7466

sbueringer opened this issue Oct 31, 2022 · 5 comments · Fixed by #7502
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

It would be great if we can pin our GitHub actions to specific commits instead of just to tags.

Recently a feature was added to dependabot (link) which makes it possible to bump actions even if they are referencing commit SHAs.

I would suggest to use the following format:

   - uses: actions/checkout@01aecccf739ca6ff86c0539fbc67a7a5007bbc81 # tag=v2.1.0

Notes:

  • We should be able to get the commit SHA's by simply taking them from the tags/releases that we currently use.

/kind feature

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 31, 2022
@sbueringer sbueringer changed the title Pin GitHub actions to commit SHA Pin GitHub actions to commit SHAs Oct 31, 2022
@sbueringer
Copy link
Member Author

/triage accepted

/help

@k8s-ci-robot
Copy link
Contributor

@sbueringer:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/triage accepted

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 31, 2022
@LuBingtan
Copy link
Contributor

Hi, I'd like to open a PR for this issue
/assign

@LuBingtan
Copy link
Contributor

#7502 PTAL 😄
Thanks!

@sbueringer
Copy link
Member Author

sbueringer commented Nov 7, 2022

Thx!

Thx to @naveensrinivasan as well for bringing this up initially via #6341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants