Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Kubernetes support matrix #3031

Merged
merged 1 commit into from
May 25, 2020
Merged

📖 Kubernetes support matrix #3031

merged 1 commit into from
May 25, 2020
+142 −0

Conversation

dlipovetsky
Copy link
Contributor

@dlipovetsky dlipovetsky commented May 8, 2020 •
edited
Loading

TODO

What this PR does / why we need it:
Documents supported versions and and compatible Kubernetes API versions

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1518

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 8, 2020
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 8, 2020
CecileRobertMichon
CecileRobertMichon approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

vincepri
vincepri approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/milestone v0.3.6

@k8s-ci-robot k8s-ci-robot added this to the v0.3.6 milestone May 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlipovetsky, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincepri
Copy link
Member

LGTM pending squash

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 11, 2020
@dlipovetsky
Copy link
Contributor Author

Thanks for the reviews, @vincepri @CecileRobertMichon @fabriziopandini!

I'd like to cover clusterctl in this doc. And upgrades. I can do that in a separate PR, though.

@vincepri
Copy link
Member

Got it, it probably makes sense to continue in this PR, wdyt?

@dlipovetsky
Copy link
Contributor Author

Got it, it probably makes sense to continue in this PR, wdyt?

SGTM. Since I saw the lgtm's, I wanted to make sure you were ok with reviewing additional changes 😄

@vincepri
Copy link
Member

/milestone v0.3.x

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.3.6, v0.3.x May 15, 2020
@vincepri
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2020
@vincepri
Copy link
Member

/hold

@dlipovetsky squash please :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2020
@dlipovetsky
Copy link
Contributor Author

Fixing typo and squashing. I wanted to cover clusterctl and upgrades, but haven't been able to. I'll revisit.

@dlipovetsky
docs: Kubernetes support matrix
ec46f28 
Signed-off-by: Daniel Lipovetsky <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2020
@dlipovetsky dlipovetsky mentioned this pull request May 22, 2020
Closed
@dlipovetsky dlipovetsky mentioned this pull request May 22, 2020
Closed
@fabriziopandini
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2020
@vincepri
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2020
@k8s-ci-robot k8s-ci-robot merged commit 99cb87a into kubernetes-sigs:master May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sedefsavas sedefsavas sedefsavas left review comments

@vincepri vincepri vincepri approved these changes

@CecileRobertMichon CecileRobertMichon CecileRobertMichon approved these changes

Assignees

@vincepri vincepri

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v0.3
Development

Successfully merging this pull request may close these issues.

[docs] Kubernetes support matrix
6 participants
@dlipovetsky @k8s-ci-robot @vincepri @fabriziopandini @CecileRobertMichon @sedefsavas