-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 use k8s-staging-test-infra/gcb-docker-gcloud #5474
🌱 use k8s-staging-test-infra/gcb-docker-gcloud #5474
Conversation
Related: - Part of: kubernetes/k8s.io#1523 - Followup to: kubernetes/test-infra#23656 Use a version of gcb-docker-cloud that is hosted in a community-owned repo instead of a google.com-owned repo Signed-off-by: Arnaud Meukam <[email protected]>
@ameukam Thx! In general lgtm. I'm not sure where we should mention the change. As we're already on v1beta1 it might be good enough to add it to the v1alpha4=>v1beta1 guide. An alternative would be to start an v1.0=>v1.1 guide (doesn't necessarily have to be in this PR, and I can take that over, if that's preferred) Let's see what others think |
+1 to document this in a new migration doc in another PR/low priority (I assume this change is happening in all the repos, so we should be fine no matter) |
Good point. I think if the same PR is opened in all CAPI repos it's fine to not document it as it's already fixed everywhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Related:
Use a version of gcb-docker-cloud that is hosted in a
community-owned repo instead of a google.com-owned repo
Signed-off-by: Arnaud Meukam [email protected]