Skip to content

Commit

Permalink
Merge pull request #1096 from vincepri/increase-verbosity
Browse files Browse the repository at this point in the history
⚠️ Remove logs from internal controller
  • Loading branch information
k8s-ci-robot authored Aug 6, 2020
2 parents 79da425 + d10e451 commit 4195d2d
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions pkg/internal/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -239,9 +239,6 @@ func (c *Controller) reconcileHandler(obj interface{}) bool {
// resource to be synced.
if result, err := c.Do.Reconcile(ctx, req); err != nil {
c.Queue.AddRateLimited(req)
if log.V(3).Enabled() {
log.Error(err, "Reconciler error")
}
ctrlmetrics.ReconcileErrors.WithLabelValues(c.Name).Inc()
ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, "error").Inc()
return false
Expand All @@ -264,9 +261,6 @@ func (c *Controller) reconcileHandler(obj interface{}) bool {
// get queued again until another change happens.
c.Queue.Forget(obj)

// TODO(directxman12): What does 1 mean? Do we want level constants? Do we want levels at all?
log.V(5).Info("Successfully Reconciled")

ctrlmetrics.ReconcileTotal.WithLabelValues(c.Name, "success").Inc()
// Return true, don't take a break
return true
Expand Down

0 comments on commit 4195d2d

Please sign in to comment.