-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
envtest: expose CRDInstallOptions via Environment #541
Comments
rajathagasthya
added a commit
to rajathagasthya/controller-runtime
that referenced
this issue
Jul 28, 2019
This change provides better control for installing CRDs in `envtest`. Fixes kubernetes-sigs#541
rajathagasthya
added a commit
to rajathagasthya/controller-runtime
that referenced
this issue
Jul 28, 2019
This change provides better control for installing CRDs in `envtest`. Fixes kubernetes-sigs#541
rajathagasthya
added a commit
to rajathagasthya/controller-runtime
that referenced
this issue
Jul 28, 2019
This change provides better control for installing CRDs in `envtest`. Closes kubernetes-sigs#541
rajathagasthya
added a commit
to rajathagasthya/controller-runtime
that referenced
this issue
Jul 28, 2019
This change provides better control for installing CRDs in `envtest`. Addresses kubernetes-sigs#541
rajathagasthya
added a commit
to rajathagasthya/controller-runtime
that referenced
this issue
Aug 19, 2019
This change provides better control for installing CRDs in `envtest`. Addresses kubernetes-sigs#541
rajathagasthya
added a commit
to rajathagasthya/controller-runtime
that referenced
this issue
Aug 20, 2019
This change provides better control for installing CRDs in `envtest`. Addresses kubernetes-sigs#541
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is related to #481. Currently, there is no way to specify
CRDInstallOptions
usingenvtest.Environment
, which means you need to workaround like this:But even with this workaround there is no way to control CRD install timeout/interval fields that are part of
CRDInstallOptions
since they are not exported (hitting an error with CRD install timing out and default timeout is too small):controller-runtime/pkg/envtest/crd.go
Lines 49 to 53 in 59b131b
So at the very least making those fields exported would be good. Another (better?) solution would be to just include
CRDInstallOptions
as a field ofEnvironment
struct and deprecateCRDs
andCRDDirectoryPaths
fields since they are already part ofCRDInstallOptions
struct.I'm happy to help with a PR if you think this is feasible!
The text was updated successfully, but these errors were encountered: