Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚠️ Remove deprecated "--master" flag #1039

Merged
merged 1 commit into from
Aug 4, 2020
Merged

⚠️ Remove deprecated "--master" flag #1039

merged 1 commit into from
Aug 4, 2020

Conversation

tanjunchen
Copy link
Member

Fixes:#1028
/cc @vincepri

@k8s-ci-robot k8s-ci-robot requested a review from vincepri July 9, 2020 14:50
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 9, 2020
@vincepri
Copy link
Member

vincepri commented Jul 9, 2020

/hold

Holding until we open the main branch to v0.7

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 9, 2020
@vincepri
Copy link
Member

vincepri commented Jul 9, 2020

Thank you for doing this!

@vincepri
Copy link
Member

vincepri commented Jul 9, 2020

/wg naming

@k8s-ci-robot k8s-ci-robot added the wg/naming Categorizes an issue or PR as relevant to WG Naming. label Jul 9, 2020
@vincepri
Copy link
Member

/milestone v0.7.x

@k8s-ci-robot k8s-ci-robot added this to the v0.7.x milestone Jul 21, 2020
@tanjunchen
Copy link
Member Author

/milestone v0.7.x

pkg/client/config/config.go:34: File is not `goimports`-ed (goimports)
	log                      = logf.RuntimeLog.WithName("client").WithName("config")

After I removed apiServerURL, what is the cause of this error?

@vincepri
Copy link
Member

/test pull-controller-runtime-test-master

@vincepri
Copy link
Member

vincepri commented Aug 4, 2020

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 4, 2020
vincepri
vincepri approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tanjunchen, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 4, 2020
@vincepri
Copy link
Member

vincepri commented Aug 4, 2020

/retitle ⚠️ Remove deprecated "--master" flag

@k8s-ci-robot k8s-ci-robot changed the title feat:remove master flag ⚠️ Remove deprecated "--master" flag Aug 4, 2020
@k8s-ci-robot k8s-ci-robot merged commit cb7f858 into kubernetes-sigs:master Aug 4, 2020
@tanjunchen tanjunchen deleted the remove-master-flag branch August 5, 2020 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. wg/naming Categorizes an issue or PR as relevant to WG Naming.
Projects
None yet
Milestone
v0.7.x
Development

Successfully merging this pull request may close these issues.
3 participants
@tanjunchen @vincepri @k8s-ci-robot