Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add Limit and Continue functional list options for client #341

Merged
merged 1 commit into from
Sep 17, 2019
Merged

✨ Add Limit and Continue functional list options for client #341

merged 1 commit into from
Sep 17, 2019

Conversation

rajathagasthya
Copy link
Contributor

Fixes #310

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 27, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2019
@rajathagasthya
Copy link
Contributor Author

@DirectXMan12 PTAL. Not quite sure about what changes to make for the fake client though, so any pointers are appreciated.

DirectXMan12
DirectXMan12 suggested changes Feb 27, 2019
View reviewed changes
Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nits inline, otherwise good work 👍

pkg/client/client_test.go Outdated Show resolved Hide resolved
pkg/client/client_test.go Outdated Show resolved Hide resolved
pkg/client/interfaces.go Outdated Show resolved Hide resolved
pkg/client/client_test.go Outdated Show resolved Hide resolved
pkg/client/client_test.go Outdated Show resolved Hide resolved
@DirectXMan12
Copy link
Contributor

if you really want to try and implement limit and continue in the fake client, that'd be ok, but I think since not everything supports limit and continue, we can just leave the fake client as-is.

@rajathagasthya rajathagasthya changed the title [WIP] ✨ Add Limit and Continue functional list options for client ✨ Add Limit and Continue functional list options for client Feb 28, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 28, 2019
@rajathagasthya
Copy link
Contributor Author

@DirectXMan12 Can you take a look when you get a chance?

DirectXMan12
DirectXMan12 suggested changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@DirectXMan12 DirectXMan12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments inline, otherwise looks good.

sorry for the review lag!

pkg/client/interfaces.go Outdated Show resolved Hide resolved
@ncdc ncdc mentioned this pull request Jul 23, 2019
Open
@rajathagasthya rajathagasthya force-pushed the listoptions-310 branch 2 times, most recently from a5965da to abec8be Compare July 24, 2019 00:31
@rajathagasthya rajathagasthya mentioned this pull request Jul 24, 2019
Merged
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 24, 2019
@rajathagasthya
Copy link
Contributor Author

Rebased on top of #536

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 25, 2019
@rajathagasthya rajathagasthya mentioned this pull request Aug 1, 2019
Closed
@rajathagasthya
Add Limit and Continue functional list options
b5dfbb5 
Adds Limit and Continue list options for pagination. Note that this
change does not support setting Limit and Continue for
`DeleteAllOfOptions` via functional options since it is not supported by
the server.
@adohe-zz
Copy link

adohe-zz commented Sep 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 1, 2019
@adohe-zz
Copy link

adohe-zz commented Sep 1, 2019

/approve

@rajathagasthya
Copy link
Contributor Author

/assign @DirectXMan12

@DirectXMan12
Copy link
Contributor

/lgtm
/approve

/retest

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adohe, DirectXMan12, rajathagasthya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit e96f830 into kubernetes-sigs:master Sep 17, 2019
@rajathagasthya rajathagasthya deleted the listoptions-310 branch September 17, 2019 22:27
DirectXMan12 pushed a commit that referenced this pull request Jan 31, 2020
@k8s-ci-robot
Merge pull request #341 from justinsb/typo_in_book_owners
c165be4 
Fix typo in book: flag is --owner, not --owners
@nimrodshn nimrodshn mentioned this pull request Jan 24, 2021
Closed
@gjkim42
Copy link
Member

gjkim42 commented Aug 7, 2023 •
edited
Loading

Does CacheReader support List function with Continue token?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DirectXMan12 DirectXMan12 DirectXMan12 requested changes

@pwittrock pwittrock Awaiting requested review from pwittrock

Assignees

@DirectXMan12 DirectXMan12

@adohe-zz adohe-zz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No list option for Continue or Limit
5 participants
@rajathagasthya @DirectXMan12 @adohe-zz @k8s-ci-robot @gjkim42