Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🏃 Make webhook marker MatchPolicy optional #411

Merged
merged 1 commit into from
Mar 11, 2020
Merged

🏃 Make webhook marker MatchPolicy optional #411

merged 1 commit into from
Mar 11, 2020

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Mar 4, 2020

Signed-off-by: Vince Prignano [email protected]

Sidenote: we need to add verification to the CI jobs

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 4, 2020
@k8s-ci-robot k8s-ci-robot requested review from droot and mengqiy March 4, 2020 19:23
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 4, 2020
@vincepri vincepri changed the title 🏃 Update webhook marker help with matchPolicy section 🏃 Make webhook marker MatchPolicy optional Mar 4, 2020
@vincepri vincepri force-pushed the generate-marker-help branch from b7e9402 to 73e8cf6 Compare March 10, 2020 23:24
@YangKeao YangKeao mentioned this pull request Mar 11, 2020
Merged
@vincepri vincepri force-pushed the generate-marker-help branch from 73e8cf6 to ae1cf39 Compare March 11, 2020 16:31
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2020
@vincepri vincepri force-pushed the generate-marker-help branch from ae1cf39 to 7e58df7 Compare March 11, 2020 16:32
@DirectXMan12
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DirectXMan12, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [DirectXMan12,vincepri]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vincepri vincepri force-pushed the generate-marker-help branch from 7e58df7 to 932c305 Compare March 11, 2020 17:04
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2020
@DirectXMan12
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 11, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1c6d384 into kubernetes-sigs:master Mar 11, 2020
@djzager djzager mentioned this pull request Mar 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajathagasthya rajathagasthya rajathagasthya left review comments

@droot droot Awaiting requested review from droot

@mengqiy mengqiy Awaiting requested review from mengqiy

Assignees

@DirectXMan12 DirectXMan12

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincepri @DirectXMan12 @k8s-ci-robot @rajathagasthya