Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return an empty LogPath from crictl inspect #1078

Closed
LinTechSo opened this issue Feb 2, 2023 · 11 comments
Closed

Return an empty LogPath from crictl inspect #1078

LinTechSo opened this issue Feb 2, 2023 · 11 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@LinTechSo
Copy link

LinTechSo commented Feb 2, 2023

Hi all.

My problem is that, after i execute below command for getting container inspect information, the Log Path field in JSON output is None and i don't know why

would you please help me figure this out.

./crictl --runtime-endpoint /host/run/dockershim.sock inspect --output=json [container_ID] | jq
{
  "status": {
    "id": "70efc011fcb7d881eb036a865569eebe8bc24c182d6225279054f96f44",
      ........
    "mounts": [],
    "logPath": "",
    "resources": null
  }
}
@LinTechSo LinTechSo added kind/bug Categorizes issue or PR as related to a bug. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Feb 2, 2023
@LinTechSo LinTechSo changed the title Return empty LogPath from crictl inspect Return an empty LogPath from crictl inspect Feb 2, 2023
@haircommander
Copy link
Contributor

what version of crictl and what CRI server are you using?

@LinTechSo
Copy link
Author

crictl version v1.25.0
Docker

some nodes are cri-o and some docker
but i see empty log path on Docker node

@haircommander
Copy link
Contributor

is it the mirantis cri-dockerd ? I don't know if anyone here is very familiar with it, it may be worth opening an issue in their repo

@LinTechSo
Copy link
Author

I'am using dockershim as runtime endpoint crictl

@haircommander
Copy link
Contributor

hm, the dockershim support was dropped in 1.24, so I think either you need to move to cri-dockerd, or totally to cri-o (as a cri-o dev, my preference is the latter 😄 )

@LinTechSo
Copy link
Author

Hi.
I have an update about this issue.

The log of my container actually exists in /host/var/lib/docker/containers and the problem comes from crictl i think

@haircommander
Copy link
Contributor

it's up to the cri server to populate that information. crictl just relays what it gets from the container status call

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 3, 2023
@SergeyKanzhelev
Copy link
Member

/close

This sounds like the dockershim issue that is not supported any longer. Just checked on containerd - logPath is populated correctly

@k8s-ci-robot
Copy link
Contributor

@SergeyKanzhelev: Closing this issue.

In response to this:

/close

This sounds like the dockershim issue that is not supported any longer. Just checked on containerd - logPath is populated correctly

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

No branches or pull requests

5 participants