Update gRPC to the latest version #499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mentioned issue in 3d04f3b is related to a limitation of cmux, where clients may block until they receive a `SETTINGS` frame. My tests were only related to CRI-O, where an appropriate fix in the project should solve the issue from a general perspective. Nevertheless, a general workaround for end-users trying to connect to a cmux based implementation might be exporting the environment variable `GRPC_GO_REQUIRE_HANDSHAKE=off`. This has been documented in the README.md as well. References: - grpc/grpc-go#2636 - https://github.com/soheilhy/cmux#limitations - cri-o/cri-o#2697 Signed-off-by: Sascha Grunert <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XXL
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feiskyer, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mentioned issue in 3d04f3b is
related to a limitation of cmux, where clients may block until they
receive a
SETTINGSframe. My tests were only related to CRI-O, wherean appropriate fix in the project should solve the issue from a general
perspective.
Nevertheless, a general workaround for end-users trying to connect to a
cmux based implementation might be exporting the environment variable
GRPC_GO_REQUIRE_HANDSHAKE=off. This has been documented in theREADME.md as well.
References: