Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For containerd/cri#1257
There are several problems with the original test:
select
instead ofswitch
;len(localOut.String()) >= len(stdout)
can't make sure that the exec is done. Fortty=true
andstdin=true
test, closing the stdin will terminate the test exec;len(localOut.String()) >= len(stdout)
logic doesn't work on windows. On windows, when tty is enabled, a lot of control characters will be generated before the actual output, e.g.:Signed-off-by: Lantao Liu [email protected]